Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5742 add youtube preview to vision page #5743

Conversation

iamonuwa
Copy link
Contributor

@iamonuwa iamonuwa commented Jan 8, 2020

Description

Add youtube embed videos to /vision page

Refers/Fixes

Fixes #5742

Testing

Go to /vision to view it.

@iamonuwa
Copy link
Contributor Author

iamonuwa commented Jan 8, 2020

Screenshot from 2020-01-08 20-01-51

@iamonuwa
Copy link
Contributor Author

iamonuwa commented Jan 8, 2020

Screenshot_20200108-200426_Chrome
Mobile

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@d70e6c5). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5743   +/-   ##
=========================================
  Coverage          ?   30.22%           
=========================================
  Files             ?      253           
  Lines             ?    21460           
  Branches          ?     3099           
=========================================
  Hits              ?     6487           
  Misses            ?    14697           
  Partials          ?      276
Impacted Files Coverage Δ
app/retail/views.py 27.67% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d70e6c5...730a14d. Read the comment docs.

@thelostone-mc thelostone-mc mentioned this pull request Jan 9, 2020
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamonuwa could we ensure the videos don't overflow the screen on mobile and videos have padding between them on mobile ?

@iamonuwa
Copy link
Contributor Author

iamonuwa commented Jan 9, 2020

@iamonuwa could we ensure the videos don't overflow the screen on mobile and videos have padding between them on mobile ?

Fixed this, thanks

@iamonuwa
Copy link
Contributor Author

iamonuwa commented Jan 9, 2020

Mobile update
image

Desktop
Screenshot from 2020-01-09 10-08-26

@iamonuwa
Copy link
Contributor Author

@thelostone-mc @octavioamu @danlipert @owocki any other issue raised?

@owocki
Copy link
Contributor

owocki commented Jan 11, 2020

LGTM but defer to the engineers for final say

@thelostone-mc thelostone-mc merged commit 05cb5e8 into gitcoinco:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add youtube videos to the /vision page
3 participants