Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save empty curve if no contributions to fix sorting #5739

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

danlipert
Copy link
Contributor

Description

This PR sets an empty clr prediction curve for grants that have no contributions, so that sorting on the grants index page works as expected

Refers/Fixes
Testing

Tested this fix in interactive shell on production

@thelostone-mc thelostone-mc merged commit 4c1b8f1 into master Jan 8, 2020
@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #5739 into master will increase coverage by 0.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5739      +/-   ##
==========================================
+ Coverage   30.01%   30.95%   +0.93%     
==========================================
  Files         254      253       -1     
  Lines       21591    22064     +473     
  Branches     3138     3267     +129     
==========================================
+ Hits         6481     6830     +349     
- Misses      14834    14936     +102     
- Partials      276      298      +22
Impacted Files Coverage Δ
app/grants/views.py 14.09% <0%> (-0.54%) ⬇️
...arketing/management/commands/new_bounties_email.py 47.05% <0%> (ø) ⬆️
app/dashboard/views.py 12.24% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️
app/app/settings.py 81.33% <0%> (+1.12%) ⬆️
app/grants/models.py 61.48% <0%> (+4.28%) ⬆️
app/dashboard/utils.py 48.68% <0%> (+7.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e77ca8...8152bbe. Read the comment docs.

@thelostone-mc thelostone-mc deleted the save-empty-curve-clr branch June 27, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants