Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include all rounds in phantom funding calc #5731

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

danlipert
Copy link
Contributor

Description

This PR includes all phantom funding selections in the grant details page

Refers/Fixes
Testing

Tested locally

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #5731 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5731   +/-   ##
=======================================
  Coverage   30.07%   30.07%           
=======================================
  Files         249      249           
  Lines       21460    21460           
  Branches     3114     3114           
=======================================
  Hits         6455     6455           
+ Misses      14729    14726    -3     
- Partials      276      279    +3
Impacted Files Coverage Δ
app/grants/views.py 14.96% <0%> (ø) ⬆️
app/dashboard/views.py 12.24% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc4ad1b...47d50a7. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice ! makes sense

@thelostone-mc thelostone-mc merged commit 36ab904 into master Jan 8, 2020
@thelostone-mc thelostone-mc deleted the phantom-grant-details-all-rounds branch June 27, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants