Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/grant submission #5716

Merged
merged 3 commits into from
Jan 6, 2020
Merged

Fix/grant submission #5716

merged 3 commits into from
Jan 6, 2020

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Jan 6, 2020

Description
  • Fix failing to blank screen when any exception
  • Add support for ens domains > to eth address
Refers/Fixes

@owocki in thread https://gitcoincore.slack.com/archives/CAXQ7PT60/p1578152474013700

Testing

https://share.vidyard.com/watch/vavVsvYhYZsTPU7gcyR4s1?

@octavioamu octavioamu changed the base branch from master to stable January 6, 2020 22:34
@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #5716 into stable will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #5716      +/-   ##
==========================================
+ Coverage   29.97%   29.98%   +<.01%     
==========================================
  Files         249      249              
  Lines       21448    21446       -2     
  Branches     3111     3110       -1     
==========================================
  Hits         6430     6430              
+ Misses      14733    14731       -2     
  Partials      285      285
Impacted Files Coverage Δ
app/grants/views.py 14.93% <0%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c63a481...d4743e5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant