Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing a mistype in tar extraction for GeoLite #5714

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

Korridzy
Copy link
Contributor

@Korridzy Korridzy commented Jan 6, 2020

Fixes: #5696

Description

fixing a mistype in tar extraction for GeoLite

Refers/Fixes

#5696

Testing

@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #5714 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5714      +/-   ##
=========================================
+ Coverage   30.08%   30.1%   +0.02%     
=========================================
  Files         249     249              
  Lines       21455   21455              
  Branches     3113    3113              
=========================================
+ Hits         6454    6460       +6     
+ Misses      14725   14719       -6     
  Partials      276     276
Impacted Files Coverage Δ
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12c4a2f...22b8a74. Read the comment docs.

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Korridzy thanks for the fix!

@danlipert danlipert merged commit d910c52 into gitcoinco:master Jan 7, 2020
androolloyd pushed a commit that referenced this pull request Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builds fail because GeoIP2 DB is no longer free
2 participants