Clr round 4 #5709
Merged
Clr round 4 #5709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## stable #5709 +/- ##
==========================================
- Coverage 29.98% 29.98% -0.01%
==========================================
Files 249 249
Lines 21447 21446 -1
Branches 3110 3110
==========================================
- Hits 6431 6430 -1
+ Misses 14731 14728 -3
- Partials 285 288 +3
Continue to review full report at Codecov.
|
| @@ -5,7 +5,6 @@ | |||
| Your contribution goes a long way! | |||
| <img class="float-right" src="{% static "v2/images/diamonds_high_fiving.gif" %}" > | |||
| </p> | |||
| {% if not show_only_estimate %} | |||
There was a problem hiding this comment.
should we replace this with clr_active ?
Line 63 in 382235c
| @@ -685,7 +685,7 @@ def grant_fund(request, grant_id, grant_slug): | |||
| 'phantom_funds': phantom_funds, | |||
| 'clr_round': clr_round, | |||
| 'total_clr_pot': total_clr_pot, | |||
| 'clr_active': clr_active, | |||
| 'clr_active': True | |||
There was a problem hiding this comment.
we can leave this as clr_active cause we've set it to True on L63
thelostone-mc
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates stable to enable grants CLR mode for round 4
Refers/Fixes
Testing
Tested Locally