Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show message that grant is being reviewed upon creation #5698

Merged
merged 2 commits into from
Jan 2, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jan 2, 2020

Description
  • will be shown only to grant team members
  • will be shown until grant is no longer hidden

GRANT CREATION

Screenshot 2020-01-02 at 3 35 01 PM

GRANT DETAILS PAGE

Screenshot 2020-01-02 at 4 02 10 PM

Refers/Fixes
Testing

@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #5698 into stable will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #5698      +/-   ##
==========================================
- Coverage   30.08%   30.02%   -0.07%     
==========================================
  Files         249      249              
  Lines       21441    21441              
  Branches     3110     3110              
==========================================
- Hits         6450     6437      -13     
- Misses      14715    14719       +4     
- Partials      276      285       +9
Impacted Files Coverage Δ
...eting/management/commands/assemble_leaderboards.py 58.11% <0%> (-5.13%) ⬇️
app/app/utils.py 22.07% <0%> (-0.67%) ⬇️
app/marketing/models.py 63.67% <0%> (+0.44%) ⬆️
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d5728...67541eb. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 49d81e1 into gitcoinco:stable Jan 2, 2020
@thelostone-mc thelostone-mc deleted the grant_alert branch January 2, 2020 14:45
@owocki
Copy link
Contributor

owocki commented Jan 2, 2020

🙌 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants