-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle ethereum wallet address #5689
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5689 +/- ##
==========================================
+ Coverage 30.09% 30.11% +0.02%
==========================================
Files 249 249
Lines 21448 21455 +7
Branches 3110 3112 +2
==========================================
+ Hits 6454 6461 +7
Misses 14718 14718
Partials 276 276
Continue to review full report at Codecov.
|
@octavioamu @owocki @danlipert reviews please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small style improvements - really nice work @iamonuwa ! I'm impressed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments, also can we fix the migrations to be only one?
@iamonuwa sweet job on the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
@owocki @danlipert @octavioamu @thelostone-mc what's left to be done here? |
Description
Allow users decide to hide or show wallet addresses
Refers/Fixes
Fixes #5654
Testing
See
/settings/privacy
and/grants/<id>/<project>/fund
to see the checkboxes.See
/profile
andgrants/<id>/<project>?tab=activity
to view it in action