Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle ethereum wallet address #5689

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Toggle ethereum wallet address #5689

merged 2 commits into from
Jan 8, 2020

Conversation

iamonuwa
Copy link
Contributor

@iamonuwa iamonuwa commented Dec 27, 2019

Description

Allow users decide to hide or show wallet addresses

Refers/Fixes

Fixes #5654

Testing

See /settings/privacy and /grants/<id>/<project>/fund to see the checkboxes.
See /profile and grants/<id>/<project>?tab=activity to view it in action

@iamonuwa
Copy link
Contributor Author

Screenshot from 2019-12-27 03-23-48
Screenshot from 2019-12-27 03-24-05

@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #5689 into master will increase coverage by 0.02%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5689      +/-   ##
==========================================
+ Coverage   30.09%   30.11%   +0.02%     
==========================================
  Files         249      249              
  Lines       21448    21455       +7     
  Branches     3110     3112       +2     
==========================================
+ Hits         6454     6461       +7     
  Misses      14718    14718              
  Partials      276      276
Impacted Files Coverage Δ
app/marketing/views.py 11.27% <0%> (-0.03%) ⬇️
app/grants/views.py 14.96% <0%> (-0.18%) ⬇️
app/dashboard/models.py 56.3% <100%> (+0.01%) ⬆️
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1a890...e05b3c7. Read the comment docs.

@iamonuwa
Copy link
Contributor Author

@octavioamu @owocki @danlipert reviews please

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small style improvements - really nice work @iamonuwa ! I'm impressed!

app/dashboard/templates/profiles/header_details.html Outdated Show resolved Hide resolved
app/grants/templates/grants/activity.html Outdated Show resolved Hide resolved
app/grants/templates/grants/activity.html Outdated Show resolved Hide resolved
app/retail/templates/settings/privacy.html Outdated Show resolved Hide resolved
Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, also can we fix the migrations to be only one?

app/retail/templates/settings/privacy.html Outdated Show resolved Hide resolved
@thelostone-mc
Copy link
Member

thelostone-mc commented Dec 30, 2019

@iamonuwa sweet job on the PR
@iamonuwa + @octavioamu + @danlipert I've addressed those review comments

Copy link
Contributor

@owocki owocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@iamonuwa
Copy link
Contributor Author

iamonuwa commented Jan 7, 2020

@owocki @danlipert @octavioamu @thelostone-mc what's left to be done here?

@danlipert danlipert merged commit fc4ad1b into gitcoinco:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants