Add option to send kudos from profile

[zoek1]

Description

1. Users now seeing a button to send kudos to this user:
   
2. When the sender user clicks the button, is redirected to the page with the user to field populated with the user info:
   

Refers/Fixes

#5661

Testing

[codecov]

Codecov Report

Merging #5683 into master will decrease coverage by 0.64%.
The diff coverage is 28.52%.

@@            Coverage Diff             @@
##           master    #5683      +/-   ##
==========================================
- Coverage   29.51%   28.87%   -0.65%     
==========================================
  Files         265      273       +8     
  Lines       22885    24331    +1446     
  Branches     3324     3576     +252     
==========================================
+ Hits         6754     7025     +271     
- Misses      15853    17023    +1170     
- Partials      278      283       +5

Impacted Files	Coverage Δ
app/bounty_requests/admin.py	100% <ø> (ø)	⬆️
app/dashboard/utils.py	39.77% <ø> (-1%)	⬇️
app/grants/urls.py	100% <ø> (ø)	⬆️
app/quests/admin.py	46.55% <0%> (-0.82%)	⬇️
app/kudos/tasks.py	34.14% <0%> (-3.7%)	⬇️
app/kudos/models.py	51.71% <0%> (-0.72%)	⬇️
app/kudos/admin.py	60.24% <0%> (-0.74%)	⬇️
...eting/management/commands/assemble_leaderboards.py	42.2% <0%> (-21.04%)	⬇️
app/quests/models.py	41.89% <0%> (-0.96%)	⬇️
app/inbox/signals.py	24.13% <0%> (+4.13%)	⬆️
... and 70 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d03bff...e71a38a. Read the comment docs.

[owocki]

thanks; does the kudos target stick as they click 'pick a kudos' and browse the marketplace too?

[owocki]

@zoek1 note that this PR differs slightly from the expected behaviour in the ticket in that the kudos to username specification will be lost when the user browses to select their kudos.. it should probably stick until cleared.

[zoek1]

Yep, I missed that. I'm changing that to persist the username with this rules:

1. Until the kudos is sent, clear persistent username
2. Until the user removes the username manually and for a max period of one day. In such a case, the stored username will be discarded.

@owocki

[zoek1]

The changes are ready @owocki, maybe three hours could be better instead of one day to remove the receiver user from local storage, what do you think?

[owocki]

@zoek1 i think 3 hours is fine.. also if the sending user clicks out of that user; then i think that should remove it too.

[zoek1]

By click out what do you mean?

1. when sending user select another user from the list or
2. when sending user select another tab to send kudos (eth address, anywhere)

[owocki]

@zoek1 both

[zoek1]

@owocki the users now is removed when:

1. When sender user selects another user from the list or
2. when sender user selects another tab to send kudos (eth address, anywhere)

[zoek1]

Sure, i'll check and fix it! El mar., 21 de enero de 2020 6:47 a. m., Dan Lipert < [email protected]> escribió:

…

***@***.**** requested changes on this pull request. ------------------------------ In app/kudos/templates/transaction/send.html <#5683 (comment)>: > + date: new Date() + })); + document.getElementById('clearSelectedUser').style.display = 'block' +{% else %} + let encoded_data = localStorage.getItem('current_receiver') + if (encoded_data !== null) { + let data = JSON.parse(encoded_data); + let current = new Date(); + let past = new Date(Date.parse(data.date)) + + if ((current.getTime() - past.getTime()) / (60 * 60) > 1440) { + localStorage.removeItem('current_receiver') + } else { + let option = document.createElement('option') + option.value = data.id + option.setAttribute('avatar_id', data.avatar_id) Theres a couple places in this PR with some spacing issues - can you take another look and clean these up? thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5683?email_source=notifications&email_token=AAFBL3LTFSBMGNKBIV7VVHTQ63VHJA5CNFSM4J65HAV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSOUCKQ#pullrequestreview-345850154>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFBL3II57XHTFPEAAGTUCLQ63VHJANCNFSM4J65HAVQ> .

[owocki]

pumped to get this live.. (once it passes code review).. seems like its close to me

[zoek1]

@owocki also this ready!

[zoek1]

fix conflicts 👍

[owocki]

pumped for this

[danlipert]

just one question about the deleted line

[danlipert]

Was this removed by mistake?

[zoek1]

🙈 Thanks, yes deleted by mistake. I just restored this line.