Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve quest feedback email" #5666

Merged
merged 3 commits into from
Jan 7, 2020
Merged

improve quest feedback email" #5666

merged 3 commits into from
Jan 7, 2020

Conversation

danlipert
Copy link
Contributor

Description

This PR improves the quest feedback email so it doesn't look as sketchy.

Refers/Fixes

fixes an issue posted in our community slack channel

Testing

not tested

@danlipert danlipert force-pushed the quest-email-feedback branch from 42d6b57 to b1acdc9 Compare January 7, 2020 10:00
@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #5666 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5666   +/-   ##
=======================================
  Coverage   30.08%   30.08%           
=======================================
  Files         249      249           
  Lines       21455    21455           
  Branches     3113     3113           
=======================================
  Hits         6454     6454           
+ Misses      14725    14722    -3     
- Partials      276      279    +3
Impacted Files Coverage Δ
app/marketing/mails.py 13.67% <0%> (ø) ⬆️
app/dashboard/views.py 12.24% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8aa7d9...b1acdc9. Read the comment docs.

@danlipert danlipert merged commit 8d29638 into master Jan 7, 2020
androolloyd pushed a commit that referenced this pull request Jan 8, 2020
* improve quest feedback email"

* fix multiline string

* Update mails.py

Co-authored-by: Aditya Anand M C <[email protected]>
@thelostone-mc thelostone-mc deleted the quest-email-feedback branch June 27, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants