Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restarts celery on deploy #5653

Merged
merged 6 commits into from
Feb 20, 2020
Merged

restarts celery on deploy #5653

merged 6 commits into from
Feb 20, 2020

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Dec 18, 2019

Description

restarts celery on deploy

Refers/Fixes

deploy channel

Testing

still working out kinks. see deploy channel

@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #5653 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5653      +/-   ##
=========================================
+ Coverage   30.05%   30.1%   +0.05%     
=========================================
  Files         248     249       +1     
  Lines       21407   22231     +824     
  Branches     3106    3348     +242     
=========================================
+ Hits         6434    6693     +259     
- Misses      14696   15238     +542     
- Partials      277     300      +23
Impacted Files Coverage Δ
app/kudos/views.py 14.59% <0%> (-1%) ⬇️
app/grants/views.py 14.4% <0%> (-0.74%) ⬇️
app/grants/management/commands/estimate_clr.py 0% <0%> (ø) ⬆️
app/grants/clr.py 0% <0%> (ø) ⬆️
app/dashboard/views.py 12.24% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️
app/kudos/tasks.py 37.83% <0%> (ø)
app/marketing/models.py 63.67% <0%> (+0.44%) ⬆️
app/app/utils.py 23.41% <0%> (+0.66%) ⬆️
app/kudos/models.py 53.59% <0%> (+1.14%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec0fa1...d1fd7fa. Read the comment docs.

 - added a check for the celery environment
@androolloyd androolloyd reopened this Jan 6, 2020
@androolloyd
Copy link
Contributor

I'll add export CELERY_NODE=1 to /etc/profile on the celery box to match this change.

@danlipert
Copy link
Contributor

@androolloyd this ready to go?

fix the restart command to include the .service designation of celery
@danlipert danlipert merged commit a848693 into master Feb 20, 2020
@thelostone-mc thelostone-mc deleted the kevin/restart_celery_on_deploy branch June 27, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants