-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Admin Address Pull on Grant #5650
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5650 +/- ##
==========================================
+ Coverage 30.05% 30.11% +0.06%
==========================================
Files 248 249 +1
Lines 21407 21448 +41
Branches 3106 3110 +4
==========================================
+ Hits 6434 6460 +26
- Misses 14696 14712 +16
+ Partials 277 276 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@molecula451 could you
- undo the indentation you had done for HTML
- also how does this fix the issue ?
grant_contract_owner_address & contract_owner_address have the same text value
So ideally if it errors out for one wouldn't the same happen for the other ?
This comment has been minimized.
This comment has been minimized.
Hi @thelostone-mc |
Description
Expected Admin Grant Address
#grant_contract_owner_address
on the Error Message but I am seeing on the file it's appending the value as#contract_owner_address
Syntax:
$('selector expression').text('content if applied');
Refers/Fixes
Line fixing
#5647
Testing
Brave Browser
This should not break any other components