Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Admin Address Pull on Grant #5650

Merged
merged 13 commits into from
Jan 3, 2020
Merged

Fix for Admin Address Pull on Grant #5650

merged 13 commits into from
Jan 3, 2020

Conversation

molecula451
Copy link
Contributor

@molecula451 molecula451 commented Dec 18, 2019

Description

Expected Admin Grant Address #grant_contract_owner_address on the Error Message but I am seeing on the file it's appending the value as #contract_owner_address

71016247-79da1d00-2127-11ea-9ef3-3a39ae3a8dfb

Syntax:

$('selector expression').text('content if applied');

Refers/Fixes

Line fixing

#5647

Testing

Brave Browser
This should not break any other components

@molecula451 molecula451 marked this pull request as ready for review December 18, 2019 01:34
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #5650 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5650      +/-   ##
==========================================
+ Coverage   30.05%   30.11%   +0.06%     
==========================================
  Files         248      249       +1     
  Lines       21407    21448      +41     
  Branches     3106     3110       +4     
==========================================
+ Hits         6434     6460      +26     
- Misses      14696    14712      +16     
+ Partials      277      276       -1
Impacted Files Coverage Δ
app/kudos/utils.py 19.85% <0%> (-0.3%) ⬇️
app/kudos/views.py 15.38% <0%> (-0.21%) ⬇️
app/kudos/models.py 52.43% <0%> (-0.02%) ⬇️
app/retail/emails.py 23.25% <0%> (ø) ⬆️
app/grants/management/commands/estimate_clr.py 0% <0%> (ø) ⬆️
app/grants/clr.py 0% <0%> (ø) ⬆️
app/kudos/tasks.py 37.83% <0%> (ø)
app/dashboard/admin.py 64.49% <0%> (+0.52%) ⬆️
app/kudos/admin.py 60.97% <0%> (+2.15%) ⬆️
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62551cb...2100e5d. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@molecula451 could you

  • undo the indentation you had done for HTML
  • also how does this fix the issue ?
    grant_contract_owner_address & contract_owner_address have the same text value
    So ideally if it errors out for one wouldn't the same happen for the other ?

@molecula451

This comment has been minimized.

@molecula451
Copy link
Contributor Author

molecula451 commented Dec 22, 2019

Hi @thelostone-mc grant_contract_owner_address" class="hidden" .hidden class has a css property of display:none inbase.csseven though the #selector it's getting the expected address value (owner address) same as contract_owner_address. It is being preventing from being display it. Which in fact I believe it's why not showing in the JQuery text

@thelostone-mc thelostone-mc merged commit cfe2ba7 into gitcoinco:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants