Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: redo landing header #5646

Merged
merged 4 commits into from
Dec 18, 2019
Merged

chore: redo landing header #5646

merged 4 commits into from
Dec 18, 2019

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Dec 17, 2019

Description

Implement new home design until the newsletter form (Future changes will come together with tribes. )

Refers/Fixes

fix #5644

Testing

localhost_8000_
localhost_8000_ (1)

@owocki
Copy link
Contributor

owocki commented Dec 17, 2019

yayyyy; pumped for this. new header looks good

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #5646 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5646      +/-   ##
==========================================
- Coverage   30.05%   30.04%   -0.02%     
==========================================
  Files         248      248              
  Lines       21406    21596     +190     
  Branches     3106     3213     +107     
==========================================
+ Hits         6434     6488      +54     
- Misses      14695    14813     +118     
- Partials      277      295      +18
Impacted Files Coverage Δ
app/app/urls.py 87.5% <0%> (-2.7%) ⬇️
app/dashboard/views.py 12.24% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️
app/avatar/models.py 35.61% <0%> (+1.36%) ⬆️
app/dashboard/notifications.py 18.85% <0%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c7fc1...207d423. Read the comment docs.

@octavioamu octavioamu marked this pull request as ready for review December 18, 2019 15:03
Copy link
Member Author

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danlipert danlipert merged commit 5880f42 into master Dec 18, 2019
@thelostone-mc thelostone-mc deleted the landing branch June 27, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DESIGN & BUILD - Homepage Design Refresh
4 participants