feat: update grants landing page #5637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new field added to grant model -> grant_type - new field added to pledge model -> pledge_type - admin view for tips + pledges + grants updated tabular - view updated to distinguish between grant types - fixed buggy search + shareable URI with filters
Codecov Report
@@ Coverage Diff @@
## master #5637 +/- ##
=========================================
+ Coverage 30.06% 30.1% +0.03%
=========================================
Files 248 248
Lines 21380 21395 +15
Branches 3102 3103 +1
=========================================
+ Hits 6427 6440 +13
- Misses 14677 14679 +2
Partials 276 276
Continue to review full report at Codecov.
|
danlipert
approved these changes
Dec 16, 2019
| @@ -110,6 +125,12 @@ def grants(request): | |||
| if grant_stats.exists(): | |||
| grant_amount = grant_stats.first().val / 1000 | |||
There was a problem hiding this comment.
maybe do the formatting to the $x k amount in the frontend instead of here? Just thinking if someone else tries to use this context var they might be confused... probably doesn't matter either way though.... what do you think?
octavioamu
suggested changes
Dec 16, 2019
octavioamu
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refers/Fixes
Testing
DEMO: https://share.vidyard.com/watch/ZhWopgeHmmTrxd5G46vhD6?
ADMIN TABULAR