ready for review - bufficorn avatar builder for ethdenver 2020 #5636
Conversation
owocki
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5636 +/- ##
=======================================
Coverage 29.36% 29.36%
=======================================
Files 270 270
Lines 23100 23100
Branches 3355 3355
=======================================
Hits 6784 6784
Misses 16027 16027
Partials 289 289Continue to review full report at Codecov.
|
owocki
changed the title
owocki
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
|
this is ready for review now! |
| @@ -856,13 +856,25 @@ def onboard(request, flow=None): | |||
| profile.preferred_payout_address = eth_address | |||
| profile.save() | |||
| return JsonResponse({'OK': True}) | |||
|
|
|||
| theme = request.GET.get('theme', '3d') | |||
| from avatar.views_3d import get_avatar_attrs | |||
|
|
||
| response = {'ids': ids, 'by_category': category_list, } | ||
| return response | ||
| response = {'ids': ids, 'by_category': category_list, } |
There was a problem hiding this comment.
this isnt actually a response, please change to a better name :)
| @@ -0,0 +1,8062 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <!-- Generator: Adobe Illustrator 23.0.1, SVG Export Plug-In . SVG Version: 6.00 Build 0) --> | |||
| <svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" | |||
There was a problem hiding this comment.
be careful with this svg and our svg optimizer because will remove all the css, I recommend to try this tool and check what you get if is fine use it instead. https://jakearchibald.github.io/svgomg/
|
|
This PR adds a new avatar builder to the site.. which can be toggled back and forth between multiple avatars (right now the standard 2d one and the 3d one)