-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 5578 chat page #5622
Issue 5578 chat page #5622
Conversation
@androolloyd Is this ready to be deployed? I see theres still a bunch of lorem ipsum |
@iamonuwa could you throw in screenshots ? |
i can update the lorem ipsum.. sholuld i do it here or on @iamonuwa s branch |
@thelostone-mc, I rebased and everytime I attempt to run it, it crashed. Am trying to fix the problem at my free time. |
@danlipert The target of this is just to my 1.2 branch to see changes sorry. Wanted to get a glimpse of what was coming into my branch before merging. |
@iamonuwa we recently moved the docker container to build from ubuntu, what issues are you having? |
i pulled this down and i cant actually find the page http://localhost:8000/chat/ just yields an empty page ( https://bits.owocki.com/GGuANrOm ) |
Codecov Report
@@ Coverage Diff @@
## chat/driver-1.2 #5622 +/- ##
====================================================
+ Coverage 15.92% 30.58% +14.65%
====================================================
Files 240 251 +11
Lines 21243 22176 +933
Branches 3074 3272 +198
====================================================
+ Hits 3384 6782 +3398
+ Misses 17846 15099 -2747
- Partials 13 295 +282
Continue to review full report at Codecov.
|
8828501d625d684008bb18d3198dfece7b7fd5fc fixes the copy issues .. here are screenshots note @androolloyd the last thing to do is link the apps, and make the 'num online' number dynamic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Satisfies 5578, will merge into the 1.2 branch
Description
Chat landing page from @iamonuwa
Refers/Fixes
#5578
Testing