Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5578 chat page #5622

Merged
merged 3 commits into from
Dec 15, 2019
Merged

Issue 5578 chat page #5622

merged 3 commits into from
Dec 15, 2019

Conversation

androolloyd
Copy link
Contributor

@androolloyd androolloyd commented Dec 11, 2019

Description

Chat landing page from @iamonuwa

Refers/Fixes

#5578

Testing

@danlipert
Copy link
Contributor

@androolloyd Is this ready to be deployed? I see theres still a bunch of lorem ipsum

@thelostone-mc
Copy link
Member

@iamonuwa could you throw in screenshots ?

@owocki
Copy link
Contributor

owocki commented Dec 11, 2019

i can update the lorem ipsum.. sholuld i do it here or on @iamonuwa s branch

@iamonuwa
Copy link
Contributor

@thelostone-mc, I rebased and everytime I attempt to run it, it crashed. Am trying to fix the problem at my free time.

@androolloyd
Copy link
Contributor Author

androolloyd commented Dec 12, 2019

@danlipert The target of this is just to my 1.2 branch to see changes sorry. Wanted to get a glimpse of what was coming into my branch before merging.

@androolloyd
Copy link
Contributor Author

@iamonuwa we recently moved the docker container to build from ubuntu, what issues are you having?

@owocki
Copy link
Contributor

owocki commented Dec 13, 2019

i pulled this down and i cant actually find the page

http://localhost:8000/chat/ just yields an empty page ( https://bits.owocki.com/GGuANrOm )

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #5622 into chat/driver-1.2 will increase coverage by 14.65%.
The diff coverage is 33.33%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chat/driver-1.2    #5622       +/-   ##
====================================================
+ Coverage            15.92%   30.58%   +14.65%     
====================================================
  Files                  240      251       +11     
  Lines                21243    22176      +933     
  Branches              3074     3272      +198     
====================================================
+ Hits                  3384     6782     +3398     
+ Misses               17846    15099     -2747     
- Partials                13      295      +282
Impacted Files Coverage Δ
app/app/urls.py 90.19% <ø> (+90.19%) ⬆️
app/dashboard/views.py 12.87% <0%> (+12.87%) ⬆️
app/retail/views.py 27.81% <50%> (+27.81%) ⬆️
app/dashboard/tasks.py 31.11% <0%> (-10.07%) ⬇️
app/chat/apps.py 0% <0%> (ø) ⬆️
app/retail/templatetags/is_in_list.py 66.66% <0%> (ø)
app/kudos/templatetags/kudos_extras.py 70% <0%> (ø)
app/retail/templatetags/strip_char.py 57.14% <0%> (ø)
app/retail/templatetags/is_in_list_type_iexact.py 66.66% <0%> (ø)
app/grants/templatetags/grants_extra.py 100% <0%> (ø)
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dcd007...d9fdb5a. Read the comment docs.

@owocki
Copy link
Contributor

owocki commented Dec 13, 2019

8828501d625d684008bb18d3198dfece7b7fd5fc fixes the copy issues .. here are screenshots

note @androolloyd the last thing to do is link the apps, and make the 'num online' number dynamic.

screencapture-localhost-8000-chat-2019-12-13-08_29_39
screencapture-localhost-8000-chat-2019-12-13-08_29_51

Copy link
Contributor Author

@androolloyd androolloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Satisfies 5578, will merge into the 1.2 branch

@androolloyd androolloyd merged commit 7aa0bd4 into gitcoinco:chat/driver-1.2 Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants