POC - bufficorn avatar builder for ETHDenver #5621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5621 +/- ##
=======================================
Coverage 30.22% 30.22%
=======================================
Files 248 248
Lines 21186 21186
Branches 3068 3068
=======================================
Hits 6403 6403
Misses 14507 14507
Partials 276 276
Continue to review full report at Codecov.
|
|
Rad! |
danlipert
approved these changes
Dec 11, 2019
danlipert
added a commit
that referenced
this pull request
Dec 11, 2019
This reverts commit 5654ad6.
danlipert
added a commit
that referenced
this pull request
Dec 11, 2019
|
@owocki During pre-deploy testing I discovered some issues with the avatar builder - theres some bug thats also on production that puts you on an odd looking onboarding screen once you save your avatar, but also the Bufficorn avatar that gets saved looks pretty jacked up. Check it out and let me know what you think |
|
shoot sorry - this was just a POC not meant to go live.. should have tagged it as such |
owocki
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bufficorn avatar builder for ETHDenver
TODO: make it so that the gitcoin platform handles multiple 3d avatar types..
need to do some work around making this a parameter