Faster CLR Calculation #5608
Merged
Faster CLR Calculation #5608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5608 +/- ##
==========================================
+ Coverage 30.05% 30.09% +0.03%
==========================================
Files 248 248
Lines 21404 21396 -8
Branches 3105 3108 +3
==========================================
+ Hits 6434 6440 +6
+ Misses 14694 14680 -14
Partials 276 276
Continue to review full report at Codecov.
|
|
how much faster is this? have we profiled it in a production like environment? |
|
@owocki so Ran both the algo against the previous clr dataset Perks of getting this PR in:
Reality:
cc @gitcoinco/engineers |
thelostone-mc
force-pushed
the
frank-clr-update
branch
2 times, most recently
from
f5b0134 to
3edef90
Compare
- udpate logger to specify which grant has no contributions - removed duplicate binary search - grant is updated + via clr only if it has contributions - reindented comments + removed print stmt
thelostone-mc
force-pushed
the
frank-clr-update
branch
from
3edef90 to
974b046
Compare
thelostone-mc
force-pushed
the
frank-clr-update
branch
from
d2e7afe to
cfc7ffb
Compare
danlipert
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added three methods:
Testing
I was going through the curve calculation part, and I believe it may break it. My concern is around line 224, but it may be that it's alright. Let's pair up and take look at that @thelostone-mc.