Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Gitcoinbot Documentation Content #5607

Merged
merged 33 commits into from
Jan 27, 2020
Merged

Fixed Gitcoinbot Documentation Content #5607

merged 33 commits into from
Jan 27, 2020

Conversation

molecula451
Copy link
Contributor

@molecula451 molecula451 commented Dec 6, 2019

Description

Our Section for GitcoinBot in the Documentation has some broken gif links which are intended to show our Bot in Action. We made some changes and update images so our users can actually see our examples.

Actual Behaviour:

issue

  • Usage Example Gif images added

added

Refers/Fixes
Testing

Chrome
Brave Browser

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b2aae79). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5607   +/-   ##
=========================================
  Coverage          ?   29.57%           
=========================================
  Files             ?      266           
  Lines             ?    22653           
  Branches          ?     3289           
=========================================
  Hits              ?     6700           
  Misses            ?    15676           
  Partials          ?      277

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2aae79...2e1df54. Read the comment docs.

@molecula451 molecula451 marked this pull request as ready for review December 6, 2019 06:28
@molecula451
Copy link
Contributor Author

@octavioamu @thelostone-mc Take a look..

docs/GITCOINBOT.md Outdated Show resolved Hide resolved
@molecula451 molecula451 requested a review from danlipert December 6, 2019 16:21
@gitcoinbot
Copy link

gitcoinbot bot commented Dec 6, 2019

No active bounty for this issue, consider create the bounty please visit this link.

PS Make sure you're logged into Metamask!

@molecula451
Copy link
Contributor Author

@thelostone-mc Review my friend

@molecula451 molecula451 changed the title Fixed Gitcoinbot Documentation Fixed Gitcoinbot Documentation Content Dec 13, 2019
@molecula451
Copy link
Contributor Author

@danlipert Updated only content, leave the rest to mkdocs

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @molecula451 - just a few fixes and this should be good to merge. Also, please don't spam the core engineers with review requests, we automatically get notified each time a commit is added or a PR is marked ready for review.

app/gitcoinbot/README.md Outdated Show resolved Hide resolved
@molecula451
Copy link
Contributor Author

@danlipert Can we end up this? can you please double-check all the most recent fixes?

@molecula451
Copy link
Contributor Author

@danlipert Up to you...

@molecula451
Copy link
Contributor Author

molecula451 commented Jan 23, 2020

@danlipert I will be happy if you finally review this asap so I can clean up my repo

@danlipert danlipert merged commit 1859f48 into gitcoinco:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants