-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mint kudos token requests (and redeem bulk kudos) in celery via a queue with retries, not on request/response cycle #5606
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5606 +/- ##
==========================================
+ Coverage 30.06% 30.48% +0.42%
==========================================
Files 248 249 +1
Lines 21380 22094 +714
Branches 3102 3252 +150
==========================================
+ Hits 6427 6736 +309
- Misses 14677 15072 +395
- Partials 276 286 +10
Continue to review full report at Codecov.
|
@androolloyd any idea what this exception is about? i followed the docs but no luck.... tried googling but then got out of my depth pretty quickly |
@danlipert just fixed the issues on this one + submitted it for reivew |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one question but good to merge this in
with open('kudos/Kudos.json') as f: | ||
abi = json.load(f) | ||
except: | ||
with open('app/kudos/Kudos.json') as f: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this some kind of prod/local difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no; i think it has to do with different base paths and therfore relative paths from celeryworkers vs gunicorn/manage.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, the paths should all be the same, but perhaps there is something preventing them or we're not starting from the right context.
Interesting to note, the failure for the auto merge is because it can't find anything in the app namespace.
Description
mint token requests (and redeem kudos) in celery via a queue with retries, not on request/response cycle
Refers/Fixes
my own todo list + request form @alexvotofuture ; no ticket
Testing
tested and working (both functions)