compliance - blocked country and user list #5602
Conversation
owocki
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5602 +/- ##
==========================================
+ Coverage 30.24% 30.38% +0.13%
==========================================
Files 247 253 +6
Lines 21165 23546 +2381
Branches 3065 3745 +680
==========================================
+ Hits 6402 7154 +752
- Misses 14487 16029 +1542
- Partials 276 363 +87
Continue to review full report at Codecov.
|
|
As we use github login and they already do this. Do we need to recheck? |
|
thats a good question to ask legal on our call with them next week. cc @frankchen07 |
app/dashboard/utils.py
Outdated
| first_name = self.user.first_name | ||
| last_name = self.user.last_name | ||
| full_name = '{first_name} {last_name}' | ||
| is_on_banned_user_list = Entitty.objects.filter(fullName__icontains=full_name) |
|
sounds like per the legal call its a good idea to have our own checking in place |
|
i turned around the code review.. |
@owocki is this you saying that its ready for final review? I see there is a note in the description that says it shouldn't be merged |
|
@danlipert just did some final testing + submitted it (removing the hedge from the desc) |
|
|
||
| def insert_entities(): | ||
| # clear existing table | ||
| Entity.objects.all().delete() |
There was a problem hiding this comment.
If we're going to ever do any kind of tracking / recording of compliance related service denial or anything like that we'll have to not rewrite this table over and over - a premature optimization for now but lets all make sure we are aware of this for the future.
There was a problem hiding this comment.
got it; @alexvotofuture should we keep a record of OFAC denials? would it be handy to have to show regulatory compliance?
|
@danlipert turned around ur feedback |
| Entity.objects.all().delete() | ||
|
|
||
| # pull data | ||
| url = 'https://www.treasury.gov/ofac/downloads/consolidated/consolidated.xml' |
There was a problem hiding this comment.
i dont understand the question?
Description
from a complilance perspective.. we do not want to do business with those in OFAC countries or on the OFAC list. this PR takes an initial stab at making sure those users cannot login to the platform
Refers/Fixes
email thread with product & legal
Testing
tested locally