Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Small Fix] Added Logo width on Contributing.md [Documentation] #5594

Merged
merged 3 commits into from
Dec 18, 2019
Merged

[Small Fix] Added Logo width on Contributing.md [Documentation] #5594

merged 3 commits into from
Dec 18, 2019

Conversation

molecula451
Copy link
Contributor

@molecula451 molecula451 commented Dec 4, 2019

Description

There is a tiny issue on our lovely 'Logo' on the contributing.md and it's happening in all screen sizes.

While the logo on contributing.md it's looking pretty good on Github. It's not in the actual deployed document site https://docs.gitcoin.co/mk_contributors/

issue

It has an automatic width of 238 x 238. Which is causing the conflict.

width

Refers/Fixes

Since it looks like we want our logo there to be bigger in size. We have added specific width in the contributing.md so it makes the logo look as we want

issue1

Issue: #4943

Testing
  • All Browsers, And all sizes.

@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #5594 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5594      +/-   ##
==========================================
+ Coverage   30.26%   30.27%   +0.01%     
==========================================
  Files         247      247              
  Lines       21142    21165      +23     
  Branches     3060     3065       +5     
==========================================
+ Hits         6398     6408      +10     
- Misses      14468    14481      +13     
  Partials      276      276
Impacted Files Coverage Δ
app/quests/views.py 25.99% <0%> (-1.2%) ⬇️
app/quests/models.py 42.85% <0%> (-0.93%) ⬇️
app/dashboard/views.py 12.87% <0%> (-0.02%) ⬇️
app/dashboard/models.py 56.28% <0%> (ø) ⬆️
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef9f30d...da0b25f. Read the comment docs.

@molecula451
Copy link
Contributor Author

@thelostone-mc Take a look my buddy.

@molecula451 molecula451 changed the title Unappropiate Logo width on Contributing.md Added Logo width on Contributing.md Dec 5, 2019
@molecula451
Copy link
Contributor Author

I am seeing this issue it's still persisent on the website documentation. Anyone reviewing? @thelostone-mc @owocki

docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
@molecula451 molecula451 changed the title Added Logo width on Contributing.md [Small Fix] Added Logo width on Contributing.md Dec 6, 2019
@molecula451 molecula451 changed the title [Small Fix] Added Logo width on Contributing.md [Small Fix] Added Logo width on Contributing.md [Documentation Dec 8, 2019
@molecula451 molecula451 changed the title [Small Fix] Added Logo width on Contributing.md [Documentation [Small Fix] Added Logo width on Contributing.md [Documentation] Dec 8, 2019
@octavioamu octavioamu merged commit 0d5efae into gitcoinco:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants