Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grants: fix team member pk casting #5592

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Conversation

danlipert
Copy link
Contributor

Description

Fixes casting of user pks when setting team members in grants

Refers/Fixes

bug noticed in pre-deploy tests

Testing

tested locally

@thelostone-mc thelostone-mc merged commit ef9f30d into master Dec 4, 2019
@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #5592 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5592      +/-   ##
==========================================
+ Coverage   30.26%   30.26%   +<.01%     
==========================================
  Files         247      247              
  Lines       21143    21142       -1     
  Branches     3060     3060              
==========================================
  Hits         6398     6398              
+ Misses      14469    14465       -4     
- Partials      276      279       +3
Impacted Files Coverage Δ
app/grants/views.py 15.47% <0%> (+0.03%) ⬆️
app/dashboard/views.py 12.88% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09334ee...d3dd50e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants