Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

responsive fixes for chat #5587

Merged
merged 3 commits into from
Dec 5, 2019
Merged

responsive fixes for chat #5587

merged 3 commits into from
Dec 5, 2019

Conversation

androolloyd
Copy link
Contributor

Description

CSS updates to provider a more responsive wrapper, originally was going to get the permission work added in but after reviewing and looking at @owocki's comments around usage for templates etc, changing to permissions in this release would be too rushed so it was held back.

Refers/Fixes

#5522 1.1 ticketing notes.

@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #5587 into master will increase coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5587      +/-   ##
==========================================
+ Coverage   30.26%   30.74%   +0.48%     
==========================================
  Files         247      247              
  Lines       21143    22704    +1561     
  Branches     3060     3593     +533     
==========================================
+ Hits         6398     6981     +583     
- Misses      14469    15394     +925     
- Partials      276      329      +53
Impacted Files Coverage Δ
app/app/urls.py 89.65% <0%> (-0.55%) ⬇️
app/dashboard/helpers.py 14.1% <0%> (-0.51%) ⬇️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️
app/grants/views.py 15.55% <0%> (+0.11%) ⬆️
app/dashboard/views.py 14.97% <0%> (+2.08%) ⬆️
app/dashboard/models.py 58.78% <0%> (+2.51%) ⬆️
app/dashboard/admin.py 69.88% <0%> (+6.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a8f6ae...01e54d4. Read the comment docs.

…sing vertical height gives a proper responsive experience
@androolloyd androolloyd changed the title responsive fixes for mobile responsive fixes for chat Dec 4, 2019
@thelostone-mc thelostone-mc merged commit d28eb16 into master Dec 5, 2019
@androolloyd androolloyd deleted the chat/1.1-fixes branch December 5, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants