Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor UI fixes across bounty #5576

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Dec 2, 2019

Description
  • mobile: fix up spacing issues in personal modal
  • mobile: ensure bounty details have padding in explorer
  • mobile + tablet: adding bottom margin for bounty categories
  • mobile + tablet: ensure total bounty fee summary doesn't break
  • mobile + tablet: ensure bounty detail summary doesn't break
  • a bunch of tiny UI fixes

Fixes

Screenshot 2019-12-02 at 8 04 09 PM

image

image

image

Screenshot 2019-12-02 at 8 15 50 PM

image

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #5576 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5576      +/-   ##
==========================================
+ Coverage   30.25%   30.27%   +0.02%     
==========================================
  Files         247      247              
  Lines       21074    21074              
  Branches     3048     3048              
==========================================
+ Hits         6375     6381       +6     
+ Misses      14423    14417       -6     
  Partials      276      276
Impacted Files Coverage Δ
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cfd8e1...8435d71. Read the comment docs.

- mobile: fix up spacing issues in personal modal
- mobile: ensure bounty details have padding in explorer
- mobile + tablet: adding bottom margin for bounty categories
- mobile + tablet: ensure total bounty fee summary doesn't break
- mobile + tablet: ensure bounty detail summar doesn't break
@octavioamu
Copy link
Contributor

@thelostone-mc What is the diff on the explorer? seems to me the second one is without any space with the end of the screen

@octavioamu
Copy link
Contributor

lol my bad the second is the actual one, now I got it

@thelostone-mc thelostone-mc merged commit 3961215 into gitcoinco:master Dec 3, 2019
@thelostone-mc thelostone-mc deleted the tinyfix branch January 16, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants