Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat 1.2 - General Availability #5569
Chat 1.2 - General Availability #5569
Changes from all commits
a7cf2ac
e50e066
52de667
3b28827
af6a0af
c7658d7
e8cc805
92f51ec
7dcd007
d9fdb5a
7aa0bd4
3bd47b5
b8d4682
7fa064d
f12ae4b
815ade9
f7ddb7e
b5421ae
c99bd50
ab1af63
74fc239
f5e3861
a305fd5
85bfa2c
5862f5f
d999b70
cc84f8b
bb474a3
48d1fe5
ed04cb5
6841897
8e36e4d
8ebe51f
7ce4f12
0e8ae42
0320c0b
bd60ba8
d64f4db
3cf01c3
393f3e8
8062d87
9b64e9e
daf8233
8fb9c2b
98caadb
64b0a73
d980117
ec21315
e722ed8
44d2ba6
b36c989
d0b7075
ff8c53b
6bc2f2a
8a7afab
81e0b3f
a50514f
a12014e
f13c985
463c35b
bf1afa9
3e01223
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the need for locks here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if 2 hunters requested to start work before a channel has been created, 2 messages could get queued to create the same channel, but if we lock with redis we dont have to worry about potentially trying to create 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is x here? Please use variable names that make sense to increase readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its a chat_id, will update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@androolloyd you probably missed this ! Could you shoot a follow up PR?