Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated activity section in bounty detail #5551

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

thelostone-mc
Copy link
Member

Description

The bounty activity section in bounty details has been cryptic and there is dead code in the js-render logic written to generate the activity.
As a funder, this makes it difficult to figure out what's happened with a bounty over the course of time

This PR

  • removes dead code
  • makes UI responsive + prettifys
  • makes the activity more readable so that folks know what exactly happens during the bounty lifecycle
IN LIVE

Screenshot 2019-11-26 at 6 31 49 PM

Screenshot 2019-11-26 at 6 32 09 PM

AFTER THIS PR

Screenshot 2019-11-26 at 5 59 36 PM

Screenshot 2019-11-26 at 5 59 49 PM

@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #5551 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5551      +/-   ##
==========================================
+ Coverage   30.25%   30.28%   +0.02%     
==========================================
  Files         247      247              
  Lines       21073    21073              
  Branches     3048     3048              
==========================================
+ Hits         6375     6381       +6     
+ Misses      14422    14416       -6     
  Partials      276      276
Impacted Files Coverage Δ
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0cd644...852c61f. Read the comment docs.

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@danlipert danlipert merged commit 52e7b73 into gitcoinco:master Nov 27, 2019
@thelostone-mc thelostone-mc deleted the bounty_details branch January 16, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants