Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix bounty details update #5518

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

thelostone-mc
Copy link
Member

Description
  • Not all bounty details updates were persisted
  • bounty details can now be updated
  • ensure documentation tag shows in bounty details
  • DRY code btwn new bounty + change bounty
Refers/Fixes

https://gitcoincore.slack.com/archives/CAXQ7PT60/p1573848437281400

Testing

https://share.vidyard.com/watch/vzJxysi2T4StLaE1Z34gfB?

- Bounty Categories + Details + Keywords
- bounty details can now be updated
- ensure documentation tag shows in bounty details
- DRY code btwn new bounty + change bounty
@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #5518 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5518      +/-   ##
==========================================
+ Coverage    29.1%   29.13%   +0.02%     
==========================================
  Files         242      242              
  Lines       20927    20929       +2     
  Branches     3026     3027       +1     
==========================================
+ Hits         6091     6097       +6     
+ Misses      14591    14587       -4     
  Partials      245      245
Impacted Files Coverage Δ
app/dashboard/views.py 12.59% <0%> (-0.02%) ⬇️
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc81988...b256c82. Read the comment docs.

@thelostone-mc thelostone-mc merged commit d283816 into gitcoinco:master Nov 20, 2019
@thelostone-mc thelostone-mc deleted the explorer branch January 16, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants