allows leaderboard to be browsed by product #5505
Conversation
owocki
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
| lrs.update(active=False) | ||
|
|
||
| # save new LR in DB | ||
| for key, rankings in ranks.items(): |
There was a problem hiding this comment.
all indentation changes from here on out
| @@ -290,6 +290,8 @@ def sum_tip_helper(t, time, index_term, val_usd): | |||
|
|
|||
| def sum_kudos(kt): | |||
| val_usd = kt.value_in_usdt_now | |||
| if not kt.kudos_token_cloned_from: | |||
| return | |||
There was a problem hiding this comment.
hmm.. what does this logic do here?
There was a problem hiding this comment.
there is a kudos transfer that has a null kudos_token_cloned_from and this logic prevents an exception here.
There was a problem hiding this comment.
ah nice thanks for the info
|
@owocki looks like we've got conflicts cause of the indentation 😓 |
Codecov Report
@@ Coverage Diff @@
## master #5505 +/- ##
==========================================
- Coverage 30.24% 29.16% -1.08%
==========================================
Files 247 242 -5
Lines 21048 20918 -130
Branches 3034 3028 -6
==========================================
- Hits 6365 6100 -265
- Misses 14407 14571 +164
+ Partials 276 247 -29
Continue to review full report at Codecov.
|
danlipert
force-pushed
the
kevin/leaderboard_by_product
branch
from
23be612 to
9046db2
Compare
|
@owocki can you take another look at this PR - seems like the tests for the leaderboard are broken. I tried a quick fix but failed |
also fixes test
|
yay! fixed. merging |
Description
allows leaderboard to be browsed by product
Refers/Fixes
https://gitcoincore.slack.com/archives/CAXQ7PT60/p1573916653291000?thread_ts=1572662544.214300&cid=CAXQ7PT60
Testing
tested locally