-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update clr formula #5494
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5494 +/- ##
==========================================
+ Coverage 29.13% 29.21% +0.08%
==========================================
Files 242 244 +2
Lines 20908 20962 +54
Branches 3022 3027 +5
==========================================
+ Hits 6091 6124 +33
- Misses 14569 14593 +24
+ Partials 248 245 -3
Continue to review full report at Codecov.
|
@thelostone-mc - I think for the sake of making an accurate QV statement, if a grant only has 1 donator, the CLR match will be 0, since that's how we're performing pairwise matching. The downside risk here is the "potential match" is marketing as well, just tough to say how effective it was compared to blasting it out on twitter and getting Vitalik's help. I say we trend towards being true and accurate to QV in the front as we are in the behind the scenes calculations, and if we want to later add something saying "get a friend to donate too and you'll get a match!" we can salvage the marketing situation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just make sure we comment out the snippet of code to ensure if no pair = no contribution.
@frankchen07 done ^_^ |
Based on the changes made by @frankchen07 after discussing with vitalik
@frankchen07 I haven't commented out the one off contribution -> let me know if that is something you would still want to remove. Cause in that case if a grant has no contributors -> it'll appear in the UI that contributing any amount would have a matching 0 as pair could not be formed
ref: thelostone-mc/clr@ef292e4
fixes: #5425