Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: prettify work details section #5479

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Nov 11, 2019

Description
  • move funder change address notification to above action buttons
  • move extra options to dropdown
  • update buttons to new style
  • refactor code + remove dead code

Demo: https://share.vidyard.com/watch/Sr8M9Um3vyjt9GWfa1Zj2R?

Current

Screenshot 2019-11-11 at 3 53 42 PM

After

Screenshot 2019-11-11 at 3 44 38 PM

closes #5347

@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #5479 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5479   +/-   ##
=======================================
  Coverage   29.61%   29.61%           
=======================================
  Files         242      242           
  Lines       20849    20849           
  Branches     3016     3016           
=======================================
  Hits         6174     6174           
  Misses      14423    14423           
  Partials      252      252

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d502d5...df426e6. Read the comment docs.

@thelostone-mc thelostone-mc force-pushed the ad branch 4 times, most recently from 8ab8d2c to c21d7ae Compare November 12, 2019 08:18
- move funder change address notification to above action buttons
- move extra options to dropdown
- update buttons to new style
- refactor code + remove dead code
@danlipert
Copy link
Contributor

@thelostone-mc looks good! Travis is failing because of an eslint error though :(

@thelostone-mc
Copy link
Member Author

@danlipert fixeddd :D

@thelostone-mc thelostone-mc merged commit 49b1f9e into gitcoinco:master Nov 12, 2019
@thelostone-mc thelostone-mc deleted the ad branch January 16, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a hackathon sponsor, the administrative actions on the issue details page aren't completely clear.
2 participants