-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some new Fixes added for Quests on Mobile UI #5463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments!
Also as opposed to using margin-top / position: absolute
Could we use boostrap classes which are already available
like
<div class="position-abosolute">
<div class="mt-2 mt-sm-0">
and so on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments!
Also as opposed to using margin-top / position: absoluteCould we use boostrap classes which are already available
like
<div class="position-abosolute">
<div class="mt-2 mt-sm-0">
and so on
Quick positioning classes are available, though they are not responsive.
@thelostone-mc If you want we can add it. But it may mess the whole code maintenance a long the way
Added New Formated Document for better readability Curly Braces identation was fixed in whole code
Codecov Report
@@ Coverage Diff @@
## master #5463 +/- ##
=========================================
- Coverage 29.64% 29.15% -0.5%
=========================================
Files 242 242
Lines 20811 20849 +38
Branches 3008 3016 +8
=========================================
- Hits 6169 6078 -91
- Misses 14387 14526 +139
+ Partials 255 245 -10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I am able to play with the whole document
-
Curly Braces Identation fixed in whole document
-
New Document Formatted for Better Code Readability
-
Added New Rules and queries for different screen ranges
-
On the stage 4 the quest answer could not be possible submitted. Linge-height of the .button class was fixed so user it's able to send it's answers Unable to click submit -metacartel quest mobile UI #5418
-
More comments for better code maintenance
I will keep adding fixes and provide updates on this specific code so our quests are always fully responsive and intuitive. If I am leaving something left behind. Please let me know in advance |
app/assets/v2/css/quests.css
Outdated
@@ -1555,7 +1555,7 @@ | |||
} | |||
body.stage_4 #header { | |||
margin-top: -2%; | |||
font-size: 12px; | |||
font-size: 8px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thelostone-mc expecting some feedback awesome mate |
@molecula451 I udpated the indentation and stuff cause I wanted to get this in before this weeks deploy ^_^ |
I was eager to know if you wanted to keep the 4-5 spaces latest indentation which was not from the original document. But it's all ok. Good stuff great friend |
Description
We recently found that our style sheets in our Quests code were a tiny bit unsorted for our Mobile UI/UX.
Quest Start on Mobile UI looked Akward:
Character Class Unsorted and unresponsive
Refers/Fixes
Unable to click submit -metacartel quest mobile UI 5418
Character should look Now:
Quest Rules Style for Mobile UI was extremely bigger. We made some fixes so it looks like
User was claiming that he actually could not submit it's answers because button was hitting the other element
There are still many elements that are not well sorted on the site and that they need to be fix. I will be providing updates on a constantly basis aswell as on style document.
Guys also. If am leaving something left behind that I am not being able to look please let me know and I will take care
Testing