Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shows quests on ajax instead of right away #5444

Merged
merged 3 commits into from
Nov 7, 2019
Merged

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Nov 4, 2019

Description

shows quests on ajax instead of right away

this is for sleep reasons..loading the quests is the most performance intensive part of the quests LP load

Refers/Fixes

#5436

Testing

tested locally

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #5444 into master will increase coverage by 0.3%.
The diff coverage is 2.17%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5444     +/-   ##
=========================================
+ Coverage   29.67%   29.97%   +0.3%     
=========================================
  Files         242      242             
  Lines       20601    20724    +123     
  Branches     2968     3031     +63     
=========================================
+ Hits         6114     6213     +99     
- Misses      14236    14259     +23     
- Partials      251      252      +1
Impacted Files Coverage Δ
app/app/urls.py 90% <ø> (ø) ⬆️
app/quests/views.py 15.04% <0%> (-0.85%) ⬇️
app/kudos/views.py 22.1% <100%> (ø) ⬆️
app/dashboard/views.py 12.94% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️
...eting/management/commands/assemble_leaderboards.py 79.17% <0%> (+4.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0050d1c...6e3e11a. Read the comment docs.

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one issue that may cause problems for folks developing on their local

app/quests/views.py Show resolved Hide resolved
app/quests/views.py Show resolved Hide resolved
@@ -59,6 +59,9 @@ <h1 class="mt-3" style="width: 100%;">{{query|title}} Quests <span id="alpha">Al
</ul>
</div>
</div>
<div class="loading w-100 {% if not show_loading %}hidden{% endif %}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

being with ajax shouldn't the logic of the loading be on the Js code? Also Seems if there is a fetching error or not results the loading is being forever. Or I'm missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

being with ajax shouldn't the logic of the loading be on the Js code?

it is?

i havent encountered a situation in which there is a fetching error.. is there one you think we should be handling?

@danlipert danlipert self-requested a review November 6, 2019 13:29
@owocki owocki merged commit 7d502d5 into master Nov 7, 2019
@thelostone-mc thelostone-mc deleted the kevin/show_quests_on_ajax branch June 27, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants