-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shows quests on ajax instead of right away #5444
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5444 +/- ##
=========================================
+ Coverage 29.67% 29.97% +0.3%
=========================================
Files 242 242
Lines 20601 20724 +123
Branches 2968 3031 +63
=========================================
+ Hits 6114 6213 +99
- Misses 14236 14259 +23
- Partials 251 252 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just one issue that may cause problems for folks developing on their local
@@ -59,6 +59,9 @@ <h1 class="mt-3" style="width: 100%;">{{query|title}} Quests <span id="alpha">Al | |||
</ul> | |||
</div> | |||
</div> | |||
<div class="loading w-100 {% if not show_loading %}hidden{% endif %}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
being with ajax shouldn't the logic of the loading be on the Js code? Also Seems if there is a fetching error or not results the loading is being forever. Or I'm missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
being with ajax shouldn't the logic of the loading be on the Js code?
it is?
i havent encountered a situation in which there is a fetching error.. is there one you think we should be handling?
Description
shows quests on ajax instead of right away
this is for sleep reasons..loading the quests is the most performance intensive part of the quests LP load
Refers/Fixes
#5436
Testing
tested locally