Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quest style to support portrait view #5422

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

zoek1
Copy link
Contributor

@zoek1 zoek1 commented Oct 30, 2019

Description

Add portrait view support for android and iphone devices and fix overlapping options and submit button.

Refers/Fixes

#5418

Testing

Android samsung galaxy s5:
Play the MetaCartel Lore Gitcoin Quest and win a Meta Cartel Kudos _ Gitcoin (1)
Play the MetaCartel Lore Gitcoin Quest and win a Meta Cartel Kudos _ Gitcoin

Iphone 5:
Play the MetaCartel Lore Gitcoin Quest and win a Meta Cartel Kudos _ Gitcoin (2) se
Play the MetaCartel Lore Gitcoin Quest and win a Meta Cartel Kudos _ Gitcoin (2)

@zoek1
Copy link
Contributor Author

zoek1 commented Oct 30, 2019

@owocki could you give me feedback of how looks the changes?

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #5422 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5422      +/-   ##
==========================================
+ Coverage   29.83%   29.86%   +0.02%     
==========================================
  Files         241      241              
  Lines       20433    20433              
  Branches     2926     2926              
==========================================
+ Hits         6096     6102       +6     
+ Misses      14086    14080       -6     
  Partials      251      251
Impacted Files Coverage Δ
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3f67c...fe5288d. Read the comment docs.

@thelostone-mc
Copy link
Member

thelostone-mc commented Nov 6, 2019

This is def a improv ❤️

@zoek1 go ahead and click on start work on the bounty so that you can get paid out on merge

@danlipert danlipert merged commit c231db3 into gitcoinco:master Nov 6, 2019
@zoek1
Copy link
Contributor Author

zoek1 commented Nov 7, 2019

@thelostone-mc i've been waiting for feedback of the proposed adaptation, but if it's ok that's awesome.
I couldn't click the start work button, someone is assigned to the work 😅.

@zoek1
Copy link
Contributor Author

zoek1 commented Nov 7, 2019

I think i can fix other little glitches at the quests, maybe this weekend i'll submit a PR 🤔

@zoek1
Copy link
Contributor Author

zoek1 commented Nov 14, 2019

This is def a improv

@zoek1 go ahead and click on start work on the bounty so that you can get paid out on merge

@owocki @thelostone-mc still could i be rewarded by this PR. Because the bounty is traditional and only one user is assigned i couldn't click the start work button, i see that other MR was merged so i don't know if that could have a conflict.

@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.35000 ETH (64.43 USD @ $184.09/ETH) has been granted to @zoek1 for this issue from @owocki. ⚡️

Nice work @zoek1! Your tip has automatically been deposited in the ETH address we have on file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants