-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quest style to support portrait view #5422
Conversation
@owocki could you give me feedback of how looks the changes? |
Codecov Report
@@ Coverage Diff @@
## master #5422 +/- ##
==========================================
+ Coverage 29.83% 29.86% +0.02%
==========================================
Files 241 241
Lines 20433 20433
Branches 2926 2926
==========================================
+ Hits 6096 6102 +6
+ Misses 14086 14080 -6
Partials 251 251
Continue to review full report at Codecov.
|
This is def a improv ❤️ @zoek1 go ahead and click on start work on the bounty so that you can get paid out on merge |
@thelostone-mc i've been waiting for feedback of the proposed adaptation, but if it's ok that's awesome. |
I think i can fix other little glitches at the quests, maybe this weekend i'll submit a PR 🤔 |
@owocki @thelostone-mc still could i be rewarded by this PR. Because the bounty is traditional and only one user is assigned i couldn't click the start work button, i see that other MR was merged so i don't know if that could have a conflict. |
⚡️ A tip worth 0.35000 ETH (64.43 USD @ $184.09/ETH) has been granted to @zoek1 for this issue from @owocki. ⚡️ Nice work @zoek1! Your tip has automatically been deposited in the ETH address we have on file.
|
Description
Add portrait view support for android and iphone devices and fix overlapping options and submit button.
Refers/Fixes
#5418
Testing
Android samsung galaxy s5:
Iphone 5: