Add shortcut to tip user #5415

zoek1 · 2019-10-29T08:44:07Z

Description

When a user adds the query parameter with a user handle, if the user exists set the user data at the tip form, if not display a error messages.

Refers/Fixes

#5346

Testing

codecov · 2019-10-29T08:50:17Z

Codecov Report

Merging #5415 into master will increase coverage by 0.39%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5415      +/-   ##
==========================================
+ Coverage   29.83%   30.23%   +0.39%     
==========================================
  Files         241      248       +7     
  Lines       20433    21200     +767     
  Branches     2926     3072     +146     
==========================================
+ Hits         6096     6409     +313     
- Misses      14086    14515     +429     
- Partials      251      276      +25

Impacted Files	Coverage Δ
app/app/urls.py	`90.19% <ø> (+0.19%)`	⬆️
app/dashboard/tip_views.py	`17.41% <0%> (-1.31%)`	⬇️
app/kudos/test_views.py	`0% <0%> (-100%)`	⬇️
app/kudos/test_models.py	`0% <0%> (-100%)`	⬇️
app/kudos/test_utils.py	`0% <0%> (-70.59%)`	⬇️
app/retail/templatetags/is_in_list.py	`66.66% <0%> (-33.34%)`	⬇️
...eting/management/commands/assemble_leaderboards.py	`61.72% <0%> (-13.38%)`	⬇️
app/kudos/views.py	`15.59% <0%> (-6.52%)`	⬇️
app/kudos/admin.py	`58.82% <0%> (-3.52%)`	⬇️
app/quests/models.py	`42.85% <0%> (-2.33%)`	⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3f67c...c82443b. Read the comment docs.

thelostone-mc · 2019-10-29T16:53:05Z

app/assets/v2/js/user-search.js

+      let existent_properties = {};
+
+      if (base_user.element) {
+        let attr = base_user.element.attributes;


would it make sense to keep this as const ?

🤔 maybe, we dont want alterate the attributes object, so const makes more sense than 'let`.

thelostone-mc · 2019-10-29T16:53:39Z

app/assets/v2/js/user-search.js

+        let attr_length = attr.length;
+
+
+        for (var i = 0; i < attr_length; i++) {


danlipert

Just one question but otherwise looks good

danlipert · 2019-11-05T12:23:22Z

app/dashboard/tip_views.py

@@ -379,5 +395,7 @@ def send_tip_2(request):
        'from_handle': from_username,
        'title': 'Send Tip | Gitcoin',
        'card_desc': 'Send a tip to any github user at the click of a button.',
+        'user_json': user,
+        'username': username


I wonder if we need to conditionally include these context params to prevent someone crafting a malicious URL and sending it to another user

Sure, added!

octavioamu · 2019-11-05T15:08:19Z

app/dashboard/templates/onepager/send2.html

 {% endblock %}
+@ratelimit(key='ip', rate='5/m', method=ratelimit.UNSAFE, block=True)


this need to be here?

That's embarrassing, i apologize for that, I remove immediately.

danlipert · 2019-11-06T13:33:26Z

app/dashboard/templates/onepager/send2.html

+  {% if not user_json and username %}
+    <script>
+    setTimeout(function() {
+      alert("Sorry, we can find the user @{{ username }}");


lets remove the username here - I'm not sure exactly how the django template injection prevention would work here, but I worry someone will create a URL with the username "); do_something_bad();

Sure, no problem. Just by reference https://docs.djangoproject.com/en/2.2/topics/security/#cross-site-scripting-xss-protection

Yeah - I'm just paranoid :) I trust the Django devs are good and all, but you can never be too careful!

danlipert · 2019-11-12T13:37:12Z

app/dashboard/templates/onepager/send2.html

@@ -172,7 +172,7 @@ <h3>{% trans "with instructions about how to receive their tip." %}</h1>
  {% if not user_json and username %}
    <script>
    setTimeout(function() {
-      alert("Sorry, we can find the user @{{ username }}");
+      alert("Sorry, we can find the user");


@thelostone-mc we should use _alert here, right?

zoek1 · 2019-11-28T06:31:31Z

@octavioamu could you review this PR? 😄

owocki · 2019-12-06T04:45:58Z

@zoek1 what would you guys think of adding a 'tip this user' button on the gitcoin profiile at https://bits.owocki.com/P8uYjrNd when this goes live? putting it next to the chat icon could be a really compelling way to drive more tips.

@octavioamu @danlipert i'm excited for this to go live! can we get some review cycles on it?

zoek1 · 2019-12-06T08:56:19Z

That would be great @owocki, definitely will be more accessible and I hope increase the tips for users. The button should be only text or will has the tip icon? Also will be the same color as the chat icon?

danlipert · 2019-12-06T15:50:32Z

app/dashboard/templates/onepager/send2.html

+  {% if not user_json and username %}
+    <script>
+    setTimeout(function() {
+      _alert("Sorry, we can find the user");


can -> can't

danlipert · 2019-12-06T15:52:38Z

app/dashboard/tip_views.py

    is_user_authenticated = request.user.is_authenticated
    from_username = request.user.username if is_user_authenticated else ''
    primary_from_email = request.user.email if is_user_authenticated else ''

+    user = {}
+    if username:
+        profiles = Profile.objects.filter(handle__icontains=username)


we should do an exact match here to prevent similar names matching: i.e. I try to tip user Dan but theres a user named DanBot. Since there's no order_by clause we can't be sure which user will get returned. Better to use iexact here.

Good catch, i already changed it! 😃

owocki · 2019-12-06T19:39:48Z

@zoek1 same color as the chat icon pls + feel free to use this fontawesome icon for it https://fontawesome.com/icons/ethereum?style=brands

zoek1 · 2019-12-09T06:53:16Z

The tip button at the user profile page look like this:

@owocki

owocki · 2019-12-09T13:53:45Z

@zoek1 looks really good! im pumped.. @danlipert can we target release this week for this

owocki · 2019-12-11T17:54:10Z

@danlipert can we target release this week for this

looks like it didnt get into the release? any objections if i test/push it myself?

Add shortcut to tip user

9e55973

zoek1 requested review from danlipert, octavioamu and thelostone-mc as code owners October 29, 2019 08:44

thelostone-mc reviewed Oct 29, 2019

View reviewed changes

Change var for let in loop and let in favor of const

0e40576

thelostone-mc approved these changes Nov 3, 2019

View reviewed changes

danlipert reviewed Nov 5, 2019

View reviewed changes

gitcoinbot mentioned this pull request Nov 5, 2019

as a user who wants to tip another user; i want to go to https://gitcoin.co/tip?username=FOO so I can easily tip that user #5346

Closed

octavioamu reviewed Nov 5, 2019

View reviewed changes

Miguel Angel G added 2 commits November 5, 2019 10:01

Remove python code wrong placed at send2.html

b17e3d0

Conditionally include user and username context params

2617bde

zoek1 requested review from danlipert and octavioamu November 5, 2019 16:09

danlipert suggested changes Nov 6, 2019

View reviewed changes

Remove username to prevent code injection

5bc023d

zoek1 requested a review from danlipert November 7, 2019 06:06

danlipert reviewed Nov 12, 2019

View reviewed changes

Update send2.html

6557d18

zoek1 requested a review from danlipert November 19, 2019 06:15

danlipert approved these changes Nov 19, 2019

View reviewed changes

danlipert suggested changes Dec 6, 2019

View reviewed changes

zoek1 added 3 commits December 8, 2019 23:57

Change search user handle to use iexact

d1f3cfd

Add tip button

170b560

fix merge conflict

c82443b

danlipert approved these changes Dec 11, 2019

View reviewed changes

owocki merged commit ce6f397 into gitcoinco:master Dec 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add shortcut to tip user #5415

Add shortcut to tip user #5415

zoek1 commented Oct 29, 2019

codecov bot commented Oct 29, 2019 •

edited

Loading

thelostone-mc Oct 29, 2019 •

edited

Loading

zoek1 Oct 30, 2019

thelostone-mc Oct 29, 2019

zoek1 Oct 30, 2019

danlipert left a comment

danlipert Nov 5, 2019

zoek1 Nov 5, 2019

octavioamu Nov 5, 2019

zoek1 Nov 5, 2019

danlipert Nov 6, 2019

zoek1 Nov 6, 2019

danlipert Nov 12, 2019

danlipert Nov 12, 2019

zoek1 Nov 14, 2019

zoek1 commented Nov 28, 2019

owocki commented Dec 6, 2019

zoek1 commented Dec 6, 2019

danlipert Dec 6, 2019

zoek1 Dec 9, 2019

danlipert Dec 6, 2019

zoek1 Dec 9, 2019

owocki commented Dec 6, 2019

zoek1 commented Dec 9, 2019

owocki commented Dec 9, 2019

owocki commented Dec 11, 2019

		let attr_length = attr.length;


		for (var i = 0; i < attr_length; i++) {

		{% endblock %}
		@ratelimit(key='ip', rate='5/m', method=ratelimit.UNSAFE, block=True)

Add shortcut to tip user #5415

Add shortcut to tip user #5415

Conversation

zoek1 commented Oct 29, 2019

Description

Refers/Fixes

Testing

codecov bot commented Oct 29, 2019 • edited Loading

Codecov Report

thelostone-mc Oct 29, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danlipert left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zoek1 commented Nov 28, 2019

owocki commented Dec 6, 2019

zoek1 commented Dec 6, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented Dec 6, 2019

zoek1 commented Dec 9, 2019

owocki commented Dec 9, 2019

owocki commented Dec 11, 2019

codecov bot commented Oct 29, 2019 •

edited

Loading

thelostone-mc Oct 29, 2019 •

edited

Loading