Add hackathon projects #5414

octavioamu · 2019-10-29T06:12:09Z

Description

Projects board (w/ filters, pagination (9 x page) winners and admin managing)
Add project (for users only available on start work and work submission)
Edit project (everyone on the project team can edit in start work, work submission or project board)
Handle multiple projects for same bounty (you can edit your current project or add a new one)
Flow prompt when starting work and when finish fulfilment (after submission is minted)
Handle image preview and square verification.
You can't remove yourself from a project

Also:

Update select2 version
Fix a problem with select2 where required select wasn't working/

Project card

Project Modal add/edition

Multiple Projects handling

Refers/Fixes

Ref: #5322 #5420

Testing

Tested locally with a lot of diff situations, and multiple bounties, hackathon and projects
https://share.vidyard.com/watch/h5d5nv916eRiAeYK5ErnHL?

codecov · 2019-10-29T23:30:12Z

Codecov Report

Merging #5414 into master will increase coverage by 0.53%.
The diff coverage is 30.88%.

@@            Coverage Diff             @@
##           master    #5414      +/-   ##
==========================================
+ Coverage   29.83%   30.36%   +0.53%     
==========================================
  Files         241      242       +1     
  Lines       20433    21954    +1521     
  Branches     2926     3445     +519     
==========================================
+ Hits         6096     6667     +571     
- Misses      14086    14984     +898     
- Partials      251      303      +52

Impacted Files	Coverage Δ
app/app/urls.py	`87.71% <ø> (-2.29%)`	⬇️
app/dashboard/views.py	`13.03% <11.22%> (+0.06%)`	⬆️
app/dashboard/admin.py	`71.29% <72.72%> (+7.58%)`	⬆️
app/dashboard/models.py	`50.77% <93.75%> (+0.3%)`	⬆️
app/quests/views.py	`15.51% <0%> (-8.9%)`	⬇️
app/quests/helpers.py	`18.6% <0%> (-2.64%)`	⬇️
app/retail/utils.py	`8.8% <0%> (-1.13%)`	⬇️
app/retail/views.py	`27.17% <0%> (-0.96%)`	⬇️
app/app/context.py	`47.45% <0%> (-0.7%)`	⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3f67c...bd4f1c3. Read the comment docs.

app/dashboard/views.py

danlipert · 2019-11-05T11:26:45Z

looks great but the vidyard link doesn't work :( @octavioamu

octavioamu · 2019-11-05T13:08:10Z

looks great but the vidyard link doesn't work :( @octavioamu

fixed, is the same video I posted in the squad channel https://share.vidyard.com/watch/h5d5nv916eRiAeYK5ErnHL?

danlipert

Looks amazing! Really nice work - just a few suggestions and fixes

app/assets/v2/js/hackathon-projects.js

danlipert · 2019-11-05T16:15:20Z

app/dashboard/templates/dashboard/index.html

@@ -53,6 +53,11 @@
          {% endif %}
          <span class="d-block font-title-lg">
            {{ hackathon.start_date|date:"M j, Y" }} - {{ hackathon.end_date|date:"M j, Y" }}
+            {% if hackathon.end_date|timeuntil >= "1 min" %}


Does the comparison here actually work? I don't think something like "8 hours" >= "1 min" works with string comparisons, but if im wrong I will be amazed at Django's usefulness :) If it turns out we need better comparison logic, according to the Django docs timeuntil will return the string "0 minutes" if the end date here is already passed so we can just check {% if hackathon.end_date|timeuntil != "0 minutes" %} https://docs.djangoproject.com/en/2.2/ref/templates/builtins/#timeuntil

Actually it works pretty well I used also on hackathon onboard. Django magic do it with the actual dates not strings .

thats crazy! magic django!

app/dashboard/views.py

danlipert · 2019-11-05T16:19:10Z

app/dashboard/views.py

+    profile = request.user.profile if request.user.is_authenticated and hasattr(request.user, 'profile') else None
+    try:
+        bounty = Bounty.objects.current().get(id=bounty_id)
+        projects = HackathonProject.objects.filter(bounty__standard_bounties_id=bounty.standard_bounties_id, profiles__id=profile.id).nocache()


For the filter query here, could we just do HackathonProject.objects.filter(bounty=bounty)?

That will work with current bounty? Because when submission the bounty id is a new one not associated with the hackathon project

ah I see, makes sense!

app/dashboard/views.py

app/assets/v2/js/hackathon-projects.js

thelostone-mc · 2019-11-06T04:34:12Z

app/dashboard/views.py

+        'projects': projects_paginated,
+        'order_by': order_by,
+        'filters': filters,
+        'query': q.split


do we wanna do a check if q exists ?

is already request.GET.get('q', '') and I use on the view if exist to show the terms is being query

thelostone-mc

left a few comments but otherwise all chill :)

octavioamu added 2 commits October 29, 2019 03:11

add hackathon projects

3bdc956

add templates

35e734d

octavioamu added 3 commits October 30, 2019 10:40

fix isort

d5a3d30

add show/hide project page button

1144fcb

add save/create and logic

c610a90

octavioamu commented Nov 4, 2019

View reviewed changes

app/dashboard/views.py Outdated Show resolved Hide resolved

octavioamu added 4 commits November 4, 2019 21:34

upgrade select2

62d0c20

migrations update

6347eca

fix query by standard bounty id and validations

dcc74d0

add project adition modal to fullfilment success

aa9ccd1

octavioamu marked this pull request as ready for review November 5, 2019 01:22

octavioamu requested review from danlipert and thelostone-mc as code owners November 5, 2019 01:22

octavioamu changed the title ~~add hackathon projects~~ Add hackathon projects Nov 5, 2019

octavioamu added 2 commits November 4, 2019 22:43

pagination and missing change

5917b08

secure img upload backend

962d7a4

danlipert suggested changes Nov 5, 2019

View reviewed changes

review fixes

2065bc4

thelostone-mc reviewed Nov 6, 2019

View reviewed changes

app/assets/v2/js/hackathon-projects.js Outdated Show resolved Hide resolved

thelostone-mc reviewed Nov 6, 2019

View reviewed changes

review comments

bd4f1c3

danlipert approved these changes Nov 6, 2019

View reviewed changes

danlipert merged commit d31397a into master Nov 6, 2019

thelostone-mc deleted the hackathon-projects branch June 27, 2020 00:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add hackathon projects #5414

Add hackathon projects #5414

octavioamu commented Oct 29, 2019 •

edited

Loading

codecov bot commented Oct 29, 2019 •

edited

Loading

danlipert commented Nov 5, 2019

octavioamu commented Nov 5, 2019

danlipert left a comment

danlipert Nov 5, 2019

octavioamu Nov 5, 2019

danlipert Nov 6, 2019

danlipert Nov 5, 2019

octavioamu Nov 5, 2019 •

edited

Loading

danlipert Nov 6, 2019

thelostone-mc Nov 6, 2019

octavioamu Nov 6, 2019

thelostone-mc left a comment

Add hackathon projects #5414

Add hackathon projects #5414

Conversation

octavioamu commented Oct 29, 2019 • edited Loading

Description

Refers/Fixes

Testing

codecov bot commented Oct 29, 2019 • edited Loading

Codecov Report

danlipert commented Nov 5, 2019

octavioamu commented Nov 5, 2019

danlipert left a comment

Choose a reason for hiding this comment

danlipert Nov 5, 2019

Choose a reason for hiding this comment

octavioamu Nov 5, 2019

Choose a reason for hiding this comment

danlipert Nov 6, 2019

Choose a reason for hiding this comment

danlipert Nov 5, 2019

Choose a reason for hiding this comment

octavioamu Nov 5, 2019 • edited Loading

Choose a reason for hiding this comment

danlipert Nov 6, 2019

Choose a reason for hiding this comment

thelostone-mc Nov 6, 2019

Choose a reason for hiding this comment

octavioamu Nov 6, 2019

Choose a reason for hiding this comment

thelostone-mc left a comment

Choose a reason for hiding this comment

octavioamu commented Oct 29, 2019 •

edited

Loading

codecov bot commented Oct 29, 2019 •

edited

Loading

octavioamu Nov 5, 2019 •

edited

Loading