bug: update scrub logic #5388
Merged
bug: update scrub logic #5388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlipert
reviewed
Oct 28, 2019
| @@ -108,7 +108,7 @@ function debounce(func, wait, immediate) { | |||
| }; | |||
| } | |||
|
|
|||
| const scrub = value => value.replace(/[\W]+/g, ''); | |||
| const scrub = value => value.replace(/[!@#$%^&*(),.?":{}|<>]+/g, ''); | |||
There was a problem hiding this comment.
I'm wondering if this opens us up at all to security risks and what the minimum characters we should allow is - I'm thinking + and # - any other weirdness out there y'all can think of?
There was a problem hiding this comment.
nope ! just those hence added those in
@octavioamu ?
thelostone-mc
force-pushed
the
keyword
branch
from
75c8c8d to
b4d0087
Compare
Codecov Report
@@ Coverage Diff @@
## master #5388 +/- ##
=========================================
+ Coverage 29.67% 29.7% +0.02%
=========================================
Files 242 242
Lines 20601 20601
Branches 2968 2968
=========================================
+ Hits 6114 6120 +6
+ Misses 14236 14230 -6
Partials 251 251
Continue to review full report at Codecov.
|
octavioamu
approved these changes
Nov 6, 2019
danlipert
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update scrub logic to show languages
Refers/Fixes
fixes #5387
Testing