Proposed fix for Kudos marketplace search bar

[0xsama]

Description

When you add whitespace in search bar value, for example: "Limited edition", the query parameters will be "Limited+edition", so when results come back in the view, the search bar get its value from query parameters (queryParam.q), so it will also show up in the search bar as Limited+edition. The simplest solution is to replace the plus signs with whitespace:\

$('#kudos-search').val(queryParam.q.replace(/+/g, " "));

I think it does look better.

Refers/Fixes

Testing

[danlipert]

@ososco nice! Thanks for the PR! In the PR description, theres a section to add how you tested your changes - here a screenshot or video would be good, or just a brief description on how you verified the changes are working. Thanks again!

[0xsama]

@danlipert

[0xsama]

Actually there is a better way to fix this with decodeURIComponent, i will commit the new fix after testing it.

[codecov]

Codecov Report

Merging #5376 into master will increase coverage by 2.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5376      +/-   ##
==========================================
+ Coverage   29.67%   32.23%   +2.55%     
==========================================
  Files         242      244       +2     
  Lines       20601    25532    +4931     
  Branches     2968     4348    +1380     
==========================================
+ Hits         6114     8231    +2117     
- Misses      14236    16898    +2662     
- Partials      251      403     +152

Impacted Files	Coverage Δ
app/app/urls.py	83.33% <0%> (-6.67%)	⬇️
app/bounty_requests/forms.py	50% <0%> (-3.85%)	⬇️
app/grants/views.py	13.99% <0%> (-2.41%)	⬇️
app/faucet/views.py	26.5% <0%> (-2.07%)	⬇️
app/kudos/views.py	20.96% <0%> (-1.14%)	⬇️
app/dashboard/tip_views.py	17.67% <0%> (-1.05%)	⬇️
app/dashboard/helpers.py	13.02% <0%> (-0.96%)	⬇️
app/kudos/utils.py	19.29% <0%> (-0.86%)	⬇️
app/bounty_requests/views.py	29.62% <0%> (-0.81%)	⬇️
app/retail/views.py	27.29% <0%> (-0.51%)	⬇️
... and 38 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0050d1c...92371e0. Read the comment docs.

[danlipert]

Nice, looks great!

[octavioamu]

@ososco I changed the base branch to be 'master'

[gitcoinbot]

⚡️ A tip worth 0.20000 ETH (38.05 USD @ $190.27/ETH) has been granted to @ososco for this issue from @owocki. ⚡️

Nice work @ososco! Your tip has automatically been deposited in the ETH address we have on file.

• $131363.14 in Funded OSS Work Available at: https://gitcoin.co/explorer
• Incentivize contributions to your repo: Send a Tip or Fund a PR
• No Email? Get help on the Gitcoin Slack

[gitcoinbot]

⚡️ A *Eye For Detail* Kudos has been sent to @ososco for this issue from @owocki. ⚡️ Nice work @ososco! Your Kudos has automatically been sent in the ETH address we have on file.