Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactors @gitcoinfeed twitter account sharing to match gitcoin.co/activity #5353

Merged
merged 2 commits into from
Oct 23, 2019

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Oct 22, 2019

Description

refactors @gitcoinfeed twitter account sharing to match gitcoin.co/activity

the reason for doing this is to cover more of the activities that happen on the platform; and to do sharing as a background task instead of upon GET request.

Refers/Fixes

self

Testing

tested locally

.  @stake-capital updated their avatar http://localhost:8000/profile/stake-capital
.  @iiitkalyanifosc updated their avatar http://localhost:8000/profile/iiitkalyanifosc
.  @arweave-sophie tipped @logitec1994 1.3000 ETH http://localhost:8000/issue/ArweaveTeam/Bounties/1/3184
.  @lolx21341 updated their avatar http://localhost:8000/profile/lolx21341
.  @lolx21341 joined Gitcoin  http://localhost:8000/profile/lolx21341
.  @alexgreen92 played Quest: Fight for Open Source Sustainability  http://localhost:8000/profile/alexgreen92
.  @muffinsthacat updated their avatar http://localhost:8000/profile/muffinsthacat
.  @sravankumarl updated their avatar http://localhost:8000/profile/sravankumarl
.  @sravankumarl joined Gitcoin  http://localhost:8000/profile/sravankumarl
.  @ajitha03 updated their avatar http://localhost:8000/profile/ajitha03
.  @ajitha03 joined Gitcoin  http://localhost:8000/profile/ajitha03
.  @royshang updated their avatar http://localhost:8000/profile/royshang
.  @alexgreen92 played Quest: Ethereum Whitepaper 101  http://localhost:8000/profile/alexgreen92
.  @royshang joined Gitcoin  http://localhost:8000/profile/royshang
.  @muffinsthacat joined Gitcoin  http://localhost:8000/profile/muffinsthacat
.  @micaebe updated their avatar http://localhost:8000/profile/micaebe
.  @regina1992 joined Gitcoin  http://localhost:8000/profile/regina1992
.  @elementsweb joined Gitcoin  http://localhost:8000/profile/elementsweb

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #5353 into master will decrease coverage by 0.06%.
The diff coverage is 4.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5353      +/-   ##
==========================================
- Coverage    29.8%   29.74%   -0.07%     
==========================================
  Files         236      237       +1     
  Lines       19891    19929      +38     
  Branches     2840     2848       +8     
==========================================
- Hits         5929     5928       -1     
- Misses      13721    13758      +37     
- Partials      241      243       +2
Impacted Files Coverage Δ
app/dashboard/views.py 12.92% <ø> (+0.02%) ⬆️
app/dashboard/helpers.py 13.98% <ø> (+0.03%) ⬆️
...pp/marketing/management/commands/share_activity.py 0% <0%> (ø)
app/dashboard/models.py 50.24% <18.18%> (-0.21%) ⬇️
app/dashboard/notifications.py 16.66% <0%> (-0.18%) ⬇️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc7e53...c3bf026. Read the comment docs.

@danlipert danlipert merged commit a6b409b into master Oct 23, 2019
@thelostone-mc thelostone-mc deleted the kevin/activity_refactor branch June 27, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants