Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: https://github.com/gitcoinco/web/issues/5291 #5351

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

ong-yy
Copy link
Contributor

@ong-yy ong-yy commented Oct 22, 2019

Description

Refs: #5310
Due to accidentally close previous PR after messing up the log.
This is same PR as #5310

The avatar is now rounded and use all existing styling.

Refers/Fixes

This PR is to fix Issue #5291

Testing

image

@thelostone-mc thelostone-mc merged commit 1296fe6 into gitcoinco:master Oct 22, 2019
@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #5351 into master will increase coverage by 1.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5351      +/-   ##
==========================================
+ Coverage    29.8%   31.45%   +1.65%     
==========================================
  Files         236      236              
  Lines       19891    21635    +1744     
  Branches     2840     3502     +662     
==========================================
+ Hits         5929     6806     +877     
- Misses      13721    14527     +806     
- Partials      241      302      +61
Impacted Files Coverage Δ
app/app/context.py 47.45% <0%> (-0.7%) ⬇️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️
app/app/urls.py 90.38% <0%> (+0.8%) ⬆️
app/dashboard/views.py 15% <0%> (+2.1%) ⬆️
app/dashboard/models.py 55.69% <0%> (+5.23%) ⬆️
app/dashboard/utils.py 47.99% <0%> (+6.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2d4f2...4b45d4a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants