Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ensure fund + detail button are always visible #5342

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Oct 19, 2019

Description

Ensure fund + view details button are always visible as opposed to be thrown to the bottom of the screen

Problem in live

Screenshot 2019-10-19 at 12 49 09 PM

After this change

https://share.vidyard.com/watch/2bzk24r5qYBqbbTYqbDijB?

@thelostone-mc thelostone-mc changed the title css: change warning from yellow to orange bug: ensure fund + detail button are always visible Oct 19, 2019
@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #5342 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5342   +/-   ##
======================================
  Coverage    29.8%   29.8%           
======================================
  Files         236     236           
  Lines       19858   19858           
  Branches     2834    2834           
======================================
  Hits         5918    5918           
  Misses      13699   13699           
  Partials      241     241

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c201ca8...b579ce1. Read the comment docs.

@octavioamu octavioamu merged commit 7147fc0 into gitcoinco:master Oct 22, 2019
@thelostone-mc thelostone-mc deleted the css branch January 16, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants