Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix username GH changes and email save new users #5335

Merged
merged 4 commits into from
Oct 23, 2019
Merged

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Oct 18, 2019

Description

Bugs this try to solve:
There is a bug with new users sync_profile not saving the email on profile obj
If someone change the username on gh data just get in sync the second time the user logins

Now users can change GH username and when login this will update username, and profile
Force to save user emails on profile

TODO: fix sync_profile to save the data the first login

Refers/Fixes

fix https://sentry.io/organizations/gitcoin/issues/1278683144/events/?project=1398424&referrer=slack

Testing

Tested with New user
Tested with a user changing GH username.

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #5335 into master will increase coverage by 0.2%.
The diff coverage is 19.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5335     +/-   ##
=========================================
+ Coverage   29.81%   30.02%   +0.2%     
=========================================
  Files         236      236             
  Lines       19884    21144   +1260     
  Branches     2838     3267    +429     
=========================================
+ Hits         5929     6349    +420     
- Misses      13711    14505    +794     
- Partials      244      290     +46
Impacted Files Coverage Δ
app/app/utils.py 21.9% <0%> (-1.32%) ⬇️
app/git/utils.py 41.5% <55.55%> (-0.28%) ⬇️
app/quests/views.py 19.76% <0%> (-5.02%) ⬇️
app/app/urls.py 86.53% <0%> (-3.05%) ⬇️
app/dashboard/views.py 13.3% <0%> (+0.35%) ⬆️
app/dashboard/models.py 50.93% <0%> (+0.48%) ⬆️
app/avatar/models.py 36.55% <0%> (+1.83%) ⬆️
app/quests/helpers.py 23.48% <0%> (+1.99%) ⬆️
app/quests/models.py 50% <0%> (+2.25%) ⬆️
app/kudos/models.py 58.25% <0%> (+4.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6721d88...580bb28. Read the comment docs.

@octavioamu octavioamu marked this pull request as ready for review October 22, 2019 14:06
@danlipert danlipert merged commit 174f842 into master Oct 23, 2019
@thelostone-mc thelostone-mc deleted the usernames-changes branch June 27, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants