Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds hackathons to nav/products page #5320

Merged
merged 6 commits into from
Oct 15, 2019
Merged

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Oct 14, 2019

Description

adds hackathons to nav/products page

Refers/Fixes

slack convo with will/alex

Testing

Screen Shot 2019-10-14 at 11 10 22 AM

Screen Shot 2019-10-14 at 11 10 17 AM

![screencapture-localhost-8000-products-2019-10-14-19_21_49](https://user-images.githubusercontent.com/513929/66792913-2691e700-eeb8-11e9-992f-197ad0de602d.png)

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #5320 into stable will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #5320      +/-   ##
==========================================
+ Coverage    29.9%   29.92%   +0.01%     
==========================================
  Files         231      233       +2     
  Lines       19321    19532     +211     
  Branches     2760     2794      +34     
==========================================
+ Hits         5778     5845      +67     
- Misses      13302    13443     +141     
- Partials      241      244       +3
Impacted Files Coverage Δ
app/retail/views.py 28.04% <ø> (ø) ⬆️
app/dashboard/views.py 13.29% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️
app/quests/helpers.py 21.17% <0%> (ø)
app/quests/quest_types/quiz_style.py 27.41% <0%> (ø)
app/quests/views.py 16.48% <0%> (+0.12%) ⬆️
app/quests/models.py 53.03% <0%> (+6.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a3a64c...fd651cc. Read the comment docs.

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment

app/retail/templates/products.html Outdated Show resolved Hide resolved
@thelostone-mc
Copy link
Member

  • compressed image
  • resize logos
  • remove himanize

@thelostone-mc thelostone-mc merged commit 88f4bc0 into stable Oct 15, 2019
@thelostone-mc thelostone-mc deleted the kevin/hackathosn-nav branch June 27, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants