Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hides kudos badges on mobile #5292 #5295

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Hides kudos badges on mobile #5292 #5295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/dashboard/templates/profiles/profile.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<div class="container profile-card mt-md-n5 mh-150">
<div class="row">
{% if total_kudos_count %}
<div id=kudos_header>
<div id="kudos_header" class="d-md-block d-none">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per https://getbootstrap.com/docs/4.3/utilities/display/ shouldn t this be .d-sm-none .d-md-block to just hide on mobile?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better yet why dont we just hide 2 of the kudos so it displays/aligns on mobile?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually no, because bootstrap is mobile first. this will showed on min like this:
image
Smaller than that will be hidden
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owocki or maybe just :
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure I am on the same page here, are you now wanting a redesign of how kudos badges are displayed rather than just hiding them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let attach to the original ticket, unless @owocki have any suggestion.
Just cleanup the changes not related to the ticket on the commit and I believe we are good.

{% for kudos_group in my_kudos %}
<img src="{{ kudos_group.kudos_token_cloned_from.preview_img_url }}" title="{{ kudos_group.kudos_token_cloned_from.name|humanize_name }}" class="img-thumbnail border-transparent kd-shadow" width="70">
{% endfor %}
Expand Down Expand Up @@ -118,4 +118,4 @@
{% endif %}
</script>
</body>
</html>
</html>