Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #logo image wider than email container #5284

Merged
merged 2 commits into from
Oct 4, 2019
Merged

fix: #logo image wider than email container #5284

merged 2 commits into from
Oct 4, 2019

Conversation

sebastiantf
Copy link
Contributor

Description

Fixes the issue of the header logo image being wider than the email container

Refers/Fixes

Fixes #5271

Testing

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #5284 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5284   +/-   ##
=======================================
  Coverage   29.89%   29.89%           
=======================================
  Files         231      231           
  Lines       19138    19138           
  Branches     2736     2736           
=======================================
  Hits         5721     5721           
  Misses      13178    13178           
  Partials      239      239

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ca089...83e5bd0. Read the comment docs.

@danlipert
Copy link
Contributor

Hey @sebastiantf thanks for this - how did you test your fix here? Do you have any screenshots?

@owocki
Copy link
Contributor

owocki commented Oct 1, 2019

speaking of testing; id be interested to know if this introduces any regressions too

@sebastiantf
Copy link
Contributor Author

sebastiantf commented Oct 1, 2019

@danlipert, I was testing it using Chrome DevTools to apply the style and it looked good.

I shall now try the instructions by @owocki to generate an email with the new styles and post a screenshot asap.

@owocki I shall check and see if this update brings back any other issues.

@thelostone-mc thelostone-mc merged commit 98d7d09 into gitcoinco:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra height for header in 'New funded issues' email on mobile
5 participants