Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defer clr contribs #5268

Merged
merged 2 commits into from
Oct 4, 2019
Merged

defer clr contribs #5268

merged 2 commits into from
Oct 4, 2019

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Sep 26, 2019

Description

the guys at status have forgotten their private key to the nimbus grant they have up.
i went back and forth with them about what to do… and heres the solution we landed upon:
i think we should open up a new grant, hide the old grant, stop all recurring contributions to the old grant, and point the CLR contributions from the old grant to the new grant.. if that sounds ok to u guys, go ahead and create the new grant and ill do the rest
technically; this would mean adding a new nullable foreign key from grant model called grant.defers_clr_to and then if it exists then all CLR contributions to the old grant are counted towards the new grant.
does this sound like an ok architecture? i think i can code it up + add it to the clr script, but @fronk ud have to add it to the postgres queries

Refers/Fixes

https://gitcoincore.slack.com/archives/CBDTKB59A/p1569423185076200

Testing

tested locally

thelostone-mc
thelostone-mc previously approved these changes Sep 30, 2019
danlipert
danlipert previously approved these changes Sep 30, 2019
@thelostone-mc thelostone-mc dismissed stale reviews from danlipert and themself via 4e027eb October 4, 2019 21:48
@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #5268 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5268      +/-   ##
==========================================
+ Coverage   29.81%   29.81%   +<.01%     
==========================================
  Files         233      233              
  Lines       19443    19445       +2     
  Branches     2782     2782              
==========================================
+ Hits         5797     5798       +1     
+ Misses      13407    13405       -2     
- Partials      239      242       +3
Impacted Files Coverage Δ
app/grants/clr.py 0% <0%> (ø) ⬆️
app/grants/models.py 60.98% <100%> (+0.1%) ⬆️
app/dashboard/views.py 13.35% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf5f68...ee9ac48. Read the comment docs.

@thelostone-mc thelostone-mc force-pushed the kevin/grant_defer_clr branch from 4e027eb to c4d2c87 Compare October 4, 2019 22:01
@thelostone-mc thelostone-mc merged commit 1ed1cd5 into master Oct 4, 2019
@thelostone-mc thelostone-mc deleted the kevin/grant_defer_clr branch October 16, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants