Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes a 3d avatar builder available along side the classic avatar builder #5257

Merged
merged 43 commits into from
Oct 3, 2019

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Sep 25, 2019

Description

makes a 3d avatar builder available along side the classic avatar builder

i think tools like this are important to remind network participants that, behind our avatars, we are all 3 dimensional humans.

Refers/Fixes

#5107

Testing

tested locally

saving new avatar:
Screen Recording 2019-09-25 at 05 33 AM_1

random avatars:
Screen Recording 2019-09-25 at 05 36 AM

classic still works
Screen Recording 2019-09-25 at 05 37 AM

@owocki owocki changed the title makes a 3d avatar builder available along side the classic avatar builder makes a 3d avatar builder available along side the classic avatar builder ( avatar builder is built; but do not merge until we have more female characters) Sep 25, 2019
@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #5257 into master will decrease coverage by 0.18%.
The diff coverage is 20.48%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5257      +/-   ##
=========================================
- Coverage   29.89%   29.7%   -0.19%     
=========================================
  Files         231     232       +1     
  Lines       19138   19286     +148     
  Branches     2736    2796      +60     
=========================================
+ Hits         5721    5729       +8     
- Misses      13178   13314     +136     
- Partials      239     243       +4
Impacted Files Coverage Δ
app/dashboard/views.py 13.42% <100%> (+0.12%) ⬆️
app/avatar/urls.py 100% <100%> (ø) ⬆️
app/avatar/models.py 34.72% <13.63%> (-3.68%) ⬇️
app/avatar/views_3d.py 18.48% <18.48%> (ø)
app/avatar/helpers.py 26.66% <26.66%> (ø)
app/avatar/utils.py 13.1% <37.5%> (ø) ⬆️
app/bounty_requests/forms.py 52% <0%> (-1.85%) ⬇️
app/quests/views.py 21.25% <0%> (-1.53%) ⬇️
app/grants/models.py 59.72% <0%> (-1.16%) ⬇️
app/kudos/models.py 53.98% <0%> (-0.61%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ca089...faec95e. Read the comment docs.

@owocki
Copy link
Contributor Author

owocki commented Sep 25, 2019

@gitcoinco/engineers would love feedback on the code! mladen is gonna deliver the female accessories on thursday so will be unblocked then

@owocki owocki changed the title makes a 3d avatar builder available along side the classic avatar builder ( avatar builder is built; but do not merge until we have more female characters) makes a 3d avatar builder available along side the classic avatar builder Sep 28, 2019
@owocki owocki removed the dont merge label Sep 28, 2019
@owocki
Copy link
Contributor Author

owocki commented Sep 28, 2019

female items are in! feel free to review !!

@owocki
Copy link
Contributor Author

owocki commented Sep 30, 2019

itll be easier to maintain than the last avatar builder bc its just a single svg to drop in/out

@owocki owocki merged commit af2035d into master Oct 3, 2019
@gitcoinco gitcoinco deleted a comment from awsamazonms Oct 14, 2019
@gitcoinco gitcoinco deleted a comment from awsamazonms Oct 14, 2019
@thelostone-mc thelostone-mc deleted the kevin/alt_avatar branch June 27, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants