allows sorting by clr estimates so that people can easily find where their $$s will go further and focus their attention there #5233
Conversation
owocki
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
owocki
changed the title
| @@ -293,6 +293,9 @@ def predict_clr(random_data=False, save_to_db=False): | |||
| if save_to_db: | |||
| grant.clr_prediction_curve = list(zip(potential_donations, potential_clr)) | |||
| grant.save() | |||
| base = grant.clr_prediction_curve[0][1] | |||
There was a problem hiding this comment.
@danlipert this adds a third array element, which is how much a specific contribution will net affect the clr match (as opposed to the previous index which is the total if they did)
There was a problem hiding this comment.
@owocki Ah this would mean we'd also have to update fund.js cause grant.clr_prediction_curve
is gonna change from [[amount, clr_match]] -> [amount, clr_match_increased_from_current]
There was a problem hiding this comment.
i dont think so. the new schema is
[[amount, clr_match, clr_match_increased_from_current]
not
[amount, clr_match_increased_from_current]
There was a problem hiding this comment.
Ohh :P lol okie makes sense
Codecov Report
@@ Coverage Diff @@
## stable #5233 +/- ##
==========================================
- Coverage 30.55% 30.53% -0.03%
==========================================
Files 223 223
Lines 18097 18110 +13
Branches 2527 2531 +4
==========================================
Hits 5529 5529
- Misses 12335 12348 +13
Partials 233 233
Continue to review full report at Codecov.
|
|
prioritizing this for sprint 19 for CLR marketing purposes. The purpose of adding the potential match for a contribution on the grants page is to help folks see where they can get furthest with CLR matching. @thelostone-mc / @willsputra / @octavioamu for setting up one last discussion on this to confirm last minute look / design changes, and make sure it's aligned with the principles of CLR. key actions:
Let's aim to get this out on the next deploy! |
|
one idea to make the layout slightly cleaner. still kinda crowded though, might explore more.
|
|
@thelostone-mc linter fixes |
|
ooh purdy |
|
@octavioamu - also made some quick fixes to the original PR while this is finalizaing |
|
Oh didn't saw that will , looks great |
|
@willsputra - can you attach the sketch file here for aditya? |
|
added to grants details too |
|
|
|
more emphasis on clr |
Description
allows sorting by clr estimates so that people can easily find where their $$s will go furthers
Refers/Fixes
https://twitter.com/owocki/status/1175530442818117633
Testing
tested locally
