FIX requests with arrays on the site #5206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavioamu
requested review from
danlipert and
thelostone-mc
as code owners
octavioamu
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
danlipert
approved these changes
Sep 19, 2019
thelostone-mc
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was first reporter as permissions not saving on the admin but actually affection any data sent by a form containing an array. Just the last one element of the array was getting into the backend so instead of
<QueryDict: {'skills[]': ['css', 'solidity'], 'bountyId': ['37']}>therequest.POSTwas getting<QueryDict: {'skills[]': [ 'solidity'], 'bountyId': ['37']}>Probably affecting lot of places on the application.For now this PR just disabled django-bleach until we solved or probably remove it as that project is very new and just have 1 issue, not enough usage.
Refers/Fixes
Fix #5190
Fix #4893
And actually any array sent, like grants team people probably failing.
Testing