-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix W3C validator issues #5201
Fix W3C validator issues #5201
Conversation
The type attribute is unnecessary for JavaScript resources.
Element script must not have attribute async unless attribute src is also specified.
An img element must have an alt attribute.
Codecov Report
@@ Coverage Diff @@
## master #5201 +/- ##
=======================================
Coverage 30.81% 30.81%
=======================================
Files 221 221
Lines 17804 17804
Branches 2457 2457
=======================================
Hits 5487 5487
Misses 12091 12091
Partials 226 226 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for these fixes! Just a few questions I had but looks good to me!
{% include 'shared/analytics.html' %} | ||
{% include 'shared/footer_scripts_lite.html' with slim=1 %} | ||
{% include 'shared/footer.html' %} | ||
{% include 'shared/messages.html' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good maybe a good idea to move the other scripts behind this comment also inside of body
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually yes, but I have based myself on existing webpages:
web/app/dashboard/templates/bounty/increase.html
Lines 162 to 192 in 6505bd5
{% include 'shared/bottom_notification.html' %} | |
{% include 'shared/analytics.html' %} | |
{% include 'shared/footer_scripts.html' %} | |
{% include 'shared/footer.html' %} | |
{% include 'shared/messages.html' %} | |
</body> | |
<script> | |
document.is_funder_github_user_same = {{ is_funder }}; | |
document.FEE_PERCENTAGE = {{ FEE_PERCENTAGE }}; | |
</script> | |
<script src="{% static "v2/js/pages/wallet_estimate.js" %}"></script> | |
<script src="{% static "v2/js/lib/ipfs-api.js" %}"></script> | |
<script src="{% static "v2/js/ipfs.js" %}"></script> | |
<script src="{% static "v2/js/lib/secrets.min.js" %}"></script> | |
<script src="{% static "v2/js/ethereumjs-accounts.js" %}"></script> | |
<script src="{% static "v2/js/lib/ipfs-api.js" %}"></script> | |
<script src="{% static "v2/js/ipfs.js" %}"></script> | |
<script src="{% static "v2/js/amounts.js" %}"></script> | |
<script src="{% static "v2/js/abi.js" %}"></script> | |
<script src="/dynamic/js/tokens_dynamic.js"></script> | |
<script src="{% static "v2/js/tokens.js" %}"></script> | |
<script src="{% static "v2/js/pages/shared_bounty_mutation_estimate_gas.js" %}"></script> | |
<script src="{% static "v2/js/pages/increase_bounty.js" %}"></script> | |
<script src="{% static "onepager/js/send.js" %}"></script> | |
</html> |
web/app/grants/templates/grants/cancel.html
Lines 107 to 125 in 6505bd5
{% include 'shared/bottom_notification.html' %} | |
{% include 'shared/analytics.html' %} | |
{% include 'shared/footer_scripts.html' %} | |
{% include 'shared/footer.html' %} | |
{% include 'grants/shared/shared_scripts.html' %} | |
</body> | |
<script src="{% static "v2/js/pages/wallet_estimate.js" %}"></script> | |
<script src="{% static "v2/js/grants/compiledSplitter.js" %}"></script> | |
<script src="{% static "v2/js/grants/compiledSubscriptionContract0.js" %}"></script> | |
<script src="{% static "v2/js/grants/compiledSubscriptionContract1.js" %}"></script> | |
<script src="{% static "v2/js/grants/compiledTokenContract.js" %}"></script> | |
<script src="{% static "v2/js/abi.js" %}"></script> | |
<script src="{% static "v2/js/pages/shared_bounty_mutation_estimate_gas.js" %}"></script> | |
<script src="{% static "v2/js/lib/ipfs-api.js" %}"></script> | |
<script src="{% static "v2/js/ipfs.js" %}"></script> | |
<script src="{% static "v2/js/grants/shared.js" %}"></script> | |
<script src="{% static "v2/js/waiting_room_entertainment.js" %}"></script> | |
<script src="{% static "v2/js/grants/cancel_subscription.js" %}"></script> | |
</html> |
web/app/grants/templates/grants/fund.html
Lines 355 to 385 in 6505bd5
{% include 'shared/bottom_notification.html' %} | |
{% include 'shared/analytics.html' %} | |
{% include 'shared/footer_scripts.html' %} | |
{% include 'shared/footer.html' %} | |
{% include 'grants/shared/shared_scripts.html' %} | |
{% if show_tweet_modal %} | |
<script> | |
$(document).ready(function(){ | |
$('#tweetModal').css('display', 'block'); | |
}); | |
</script> | |
{% endif %} | |
</body> | |
<script src="{% static "v2/js/pages/wallet_estimate.js" %}"></script> | |
<script src="{% static "v2/js/grants/compiledSplitter.js" %}"></script> | |
<script src="{% static "v2/js/grants/compiledSubscriptionContract0.js" %}"></script> | |
<script src="{% static "v2/js/grants/compiledSubscriptionContract1.js" %}"></script> | |
<script src="{% static "v2/js/grants/compiledTokenContract.js" %}"></script> | |
<script src="/dynamic/js/tokens_dynamic.js"></script> | |
<script src="{% static "v2/js/tokens.js" %}"></script> | |
<script src="{% static "v2/js/abi.js" %}"></script> | |
<script src="{% static "v2/js/pages/shared_bounty_mutation_estimate_gas.js" %}"></script> | |
<script src="{% static "v2/js/grants/shared.js" %}"></script> | |
<script src="{% static "v2/js/grants/fund.js" %}"></script> | |
<script src="{% static "v2/js/lib/ipfs-api.js" %}"></script> | |
<script src="{% static "v2/js/ipfs.js" %}"></script> | |
<script src="{% static "v2/js/waiting_room_entertainment.js" %}"></script> | |
</html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, yes good point we should fix that in some point (not for this PR)
Description
Following issues are reported by the W3C validator and have been fixed.
Testing
✓ Frontend tests